Created free-courses-gr.md and added a JavaScript Course #5693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check_urls=free-programming-books.md free-programming-books-gr.md
|
Locks #5689 |
davorpa
requested changes
Oct 1, 2021
There was a problem hiding this comment.
New listings is always welcome 🎉
To complete this... could you be able to link this new listing in README.md?
It's not necesary make another PR. Only edit this resource, commit, and push.
https://github.com/anneiric/free-programming-books/blob/master/README.md#free-online-courses
I can guide you if some is wrong. This is the snippet:
+ [German / Deutsch](courses/free-courses-de.md)
+ [Greek / ελληνικά](books/free-courses-gr.md)
+ [Hebrew / עברית](courses/free-courses-he.md)
Insert only the Greek part between German and Hebrew. So, we preserve listing alphabetization
davorpa
added
the
waiting for changes
|
This PR needs be recovered from HEAD refs since source fork was deleted /labelthis: detached |
|
language code for greek is el not gr #6070 |
|
Added to backlog #5762
|
39 tasks
davorpa
added a commit
to davorpa/free-programming-books
that referenced
this pull request
Oct 11, 2021
Recover deleted PR head: git fetch upstream pull/5693/head:pr/anneiric/5693 anneiric <[email protected]>
davorpa
added a commit
to davorpa/free-programming-books
that referenced
this pull request
Oct 11, 2021
language code for greek is `el` not `gr`. See: EbookFoundation#6070 Applies EbookFoundation#5693 (comment)
davorpa
added a commit
to davorpa/free-programming-books
that referenced
this pull request
Oct 11, 2021
Link recent created greek courses listing `books/free-courses-el.md` into `README.md` Resolves EbookFoundation#5693
davorpa
added a commit
to davorpa/free-programming-books
that referenced
this pull request
Oct 11, 2021
Link `courses/free-courses-el.md` into `README.md` Resolves EbookFoundation#5693
5 tasks
davorpa
approved these changes
Oct 11, 2021
eshellman
pushed a commit
that referenced
this pull request
Oct 11, 2021
* Create free-courses-gr.md and added JavaScript course check_urls=free-programming-books.md free-programming-books-gr.md * Update free-courses-gr.md * Bumps review #5693 Recover deleted PR head: git fetch upstream pull/5693/head:pr/anneiric/5693 anneiric <[email protected]> * fix(listings): greek language code `gr` > `el` language code for greek is `el` not `gr`. See: #6070 Applies #5693 (comment) * feat(courses): Add greek entry Link recent created greek courses listing `books/free-courses-el.md` into `README.md` Resolves #5693 * feat(courses): Add greek entry Link `courses/free-courses-el.md` into `README.md` Resolves #5693 Co-authored-by: anneiric <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created free-courses-gr.md and added a Greek JavaScript Course
What does this PR do?
Add resource
For resources
Description
Introduction in Web Development with JavaScript in Greek.
Why is this valuable (or not)?
It teaches JavaScript in Greek and has different modules on each topic.
How do we know it's really free?
It is mentioned as free in the website
For book lists, is it a book? For course lists, is it a course? etc.
It is a course.
Checklist:
Follow-up