-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emscripten: FPS counter broke, showing more than 60 fps #2444
Comments
Here for comparison: With Asyncify: Without (correct frame counter): Please also check, besides looking at the frame counter, what feels "smoother" for you. Also added a fix for our easteregg (#1899) Imo the version with Asyncify feels less choppy. The one without sometimes hangs for short moments. |
Frozen Triggers desktop test, I feel the scroll while displacing between the snowy weather and the cavern smoother in the "Without" version. It jumps slightly more with the Asyncify version here. (Firefox on Ryzen 5 2400G on Fedora 34 GNOME 40) Frozen Triggers mobile test, with Asynficy: bad performance as expected, maybe 4 fps. But without Asyncify it gets even worse: not even loading the snow or audio, slow asset loading, even slower FPS. (Firefox on a low end quad core mediatek Android Go potatophone 1 gb ram) Testgame scrolling works smoother to me on both desktop and mobile without asyncify, so it seems the frozen triggers issue on mobile is related to the 0fps somehow. |
Also pinging the others: Could you please compare the Async vs. No async version on both your Computer and your Smartphone and tell me which feels "smoother". This is highly subjective so we must find consense first. |
The Asyncify version is way smoother for me than the no async version. Tested the desktop versions, because due to not possessing a smartphone I could not test the mobile versions. Desktop PC specs: |
The web player FPS counter which appears whith the F2 key regressed likely since major changes allowing frameskip and fast forward since WebAssembly landed.
Ideally, should get a count similar to JavaScript's requestAnimationFrame, which is based on system refresh rate.
The text was updated successfully, but these errors were encountered: