Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture flash doesn't work on lower layers #1978

Open
mateofio opened this issue Dec 7, 2019 · 1 comment
Open

Picture flash doesn't work on lower layers #1978

mateofio opened this issue Dec 7, 2019 · 1 comment

Comments

@mateofio
Copy link
Contributor

mateofio commented Dec 7, 2019

Because of the way we blit flash effects to the screen, pictures on layers below weather misbehave.

player_flash

The left are all layers unaffected by flash, the right affected by flash.

All the clouds are supposed to look like the bottom row.

@mateofio
Copy link
Contributor Author

I thinking for this one. Maybe the optimal solution is:

  1. In z order render all drawables that are affected by flash, without the effect, until the first one that isn't.
  2. Render flash on the entire display
  3. Now render remaining drawables in Z order, flashing each one individually if it's affected.

For most games which don't use lower layer pictures unaffected by flash, this would maintain the optimization we currently have.

The same can be done for tone.

@Ghabry Ghabry added this to the 0.7.2 milestone May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants