Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter PR Todo Items #1859

Closed
7 of 8 tasks
mateofio opened this issue Jul 31, 2019 · 3 comments · Fixed by #2208
Closed
7 of 8 tasks

Interpreter PR Todo Items #1859

mateofio opened this issue Jul 31, 2019 · 3 comments · Fixed by #2208

Comments

@mateofio
Copy link
Contributor

mateofio commented Jul 31, 2019

While we slog through the interpreter PR's here is the list of todo items which are being postponed to avoid rebase issues

  • Remove Game_Map::RefreshType
  • Cleanup Game_Interpreter::GetFrame()
  • Streamline Game_Map::RequestMap() logic in one place. Currently in Game_Player, Scene_Map, and Scene_Debug. Should be after Implement fully async transitions #1784 is merged.
  • Remove Async globals and store the async reason and parameters in the AsyncContext
  • Should we verify save game command chunks against event commands in Refactor Interpreter Stack Frame Completion  #1884? How does RPG_RT do it?
  • Are level up / skill learned messages word wrapped? Check EXP, Level, and Class Change.
  • Can self destruct / escape be undone with show enemy command? - YES
  • Verify what happens if we change event page after event erased. What happens to LSD chunks?
@fdelapena fdelapena added this to the 0.6.2 milestone Jul 31, 2019
@Ghabry
Copy link
Member

Ghabry commented Aug 4, 2019

TBD: Fix performance issues caused by #1740 . Need to confirm my test was correct when back home.

@fdelapena fdelapena added the MIDI label Jan 13, 2020
@mateofio
Copy link
Contributor Author

mateofio commented Mar 7, 2020

Confirmed the following in RPG_RT:

  • Enemy escapes, event show enemy - reappears
  • Enemy self-destructs, event show enemy - reappears
  • Enemy dies, event show enemy - stays dead

Also confirmed current master emulates these

@mateofio
Copy link
Contributor Author

mateofio commented Mar 7, 2020

Remove the MIDI bullet as thats already tracked by #1733

@Ghabry Ghabry modified the milestones: 0.6.2, 0.6.3 Mar 31, 2020
@Ghabry Ghabry modified the milestones: 0.6.3, 0.7.0 Apr 9, 2020
@Ghabry Ghabry modified the milestones: 0.7.0, 0.6.3 Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants