Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text overlaps with face on teleport #1781

Closed
pulsejet opened this issue May 28, 2019 · 5 comments · Fixed by #1890
Closed

Text overlaps with face on teleport #1781

pulsejet opened this issue May 28, 2019 · 5 comments · Fixed by #1890

Comments

@pulsejet
Copy link

Please fill in the following fields before submitting an issue:

Name of the game:

Ahriman's Prophecy

Player platform:

Windows, Android (probably all)

Describe the issue in detail and how to reproduce it:

On displaying a message with a face to the left after teleporting from inside a common event, the face is displayed but the offset for the text gets unset for all except the first line. So the first line shows up with the proper offset but the rest of the text overlaps with the face.

@pulsejet
Copy link
Author

Ugh, for some reason the game defines a bunch of parallel process common events the first statement for all of which is to reset the face graphic to nothing (along with other things below in a conditional). The fact that this does work with RPG_RT does indicate some deviation of behavior from the original implementation though.

@Ghabry
Copy link
Member

Ghabry commented May 28, 2019

No need to close this yet, as we behave different to RPG_RT we consider this a bug in our implementation, even if RPG_RTs behaviour is strange.

@Ghabry Ghabry reopened this May 28, 2019
@Ghabry Ghabry added this to the 0.6.2 milestone May 28, 2019
@mateofio
Copy link
Contributor

mateofio commented May 29, 2019

This appears more complicated to reproduce. However it could offer valuable insight into investigating #1706

@pulsejet Do you have a save game near where it happens in the example game?

@pulsejet
Copy link
Author

I've isolated a minimal test case here (RTP dependent, let me know if this is not okay)

Basically, all you need is is one event that the player can interact which has

SetFace (1)
ShowMessage (1)
Teleport (to another map)
SetFace (2)
ShowMessage (2)

and one parallel process common event with just

SetFace (Erase)

The second line of message 2 should overlap with the face. Note that it's necessary to telepoprt to a different map, not the one you're on right now.

@mateofio
Copy link
Contributor

mateofio commented Aug 27, 2019

This is fixed by #1876

Also I was confused, @pulsejet were you just saying Player does this? Or RPG_RT also does it?

I tested RPG_RT steam versions of 2k and 2k3 and did not see the big. I only see it in player current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment