StringVar: address popLine edge case behavior to match maniacs

EasyRPG · Feb 20, 2025 · f92e6c4 · f92e6c4
1 parent 6260f41
commit f92e6c4
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/game_strings.cpp b/src/game_strings.cpp
@@ -282,8 +282,12 @@ StringView Game_Strings::PopLine(Str_Params params, int offset, int string_out_i
 
 	Set(params, ss.str().substr(str.length() - offset));
 
-	params.string_id = string_out_id;
-	Set(params, result);
+	// the maniacs implementation is to always preserve the mutated base string
+	// so in the case where the out_id matches the base string id, the popped line is discarded.
+	if (string_out_id != params.string_id) {
+		params.string_id = string_out_id;
+		Set(params, result);
+	}
 	return Get(params.string_id);
 }