Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration file path #115

Open
mpiot opened this issue Jun 8, 2020 · 1 comment
Open

Configuration file path #115

mpiot opened this issue Jun 8, 2020 · 1 comment

Comments

@mpiot
Copy link

mpiot commented Jun 8, 2020

Hi everyone,
I've a little suggest about the configuration path, in my Symfony 5 project the Bundle search config in:

  config/
      packages/
      prod/
          deploy.php <- Here
      routes/
      secrets/
      staging/
          deploy.php <- Here
      bootstrap.php
      bundles.php
      routes.yaml
      services.yaml

It would seem preferable to :

  config/
      packages/
      routes/
      secrets/
      bootstrap.php
      bundles.php
      deploy_prod.php <- Here
      deploy_staging.php <- Here
      routes.yaml
      services.yaml

Or :

  config/
      deployments/ <- Same as packages/
          prod/
              deploy.php <- Here
          staging/
              deploy.php <- Here
      packages/
      routes/
      secrets/
      bootstrap.php
      bundles.php
      routes.yaml
      services.yaml

This is write in EasyCorp\Bundle\EasyDeployBundle\Helper, the default behavior (LEGACY_CONFIG_DIR) is the one I expect, but 3 years ago a change was made to use subdir to put deploy.php inside a subdir. Someone know why this change was made ?

@nacholibre
Copy link

I agree, also in the configuration example the path suggested is app/config/deploy_prod.php, but in reality when you run the deploy command in it says There is no config file to deploy 'env' env.

From the suggestions @mpiot gave above, I'll prefer config/deployments/ structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants