Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSR support #2

Open
ehellman opened this issue May 22, 2019 · 1 comment
Open

SSR support #2

ehellman opened this issue May 22, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@ehellman
Copy link

There's heavy usage of document and window, neither of which exists in the Node environment. You should include this package in a SSR project and try to make it work. Wrap window/document in conditionals and sometimes you have to rewrite some parts to make sure that server has a reasonable substitute or just doesn't run this at all. I've fought quite a lot with this before myself, this is by far the easiest way to deal with the problem :D
@carlcalderon carlcalderon added the enhancement New feature or request label May 22, 2019
@carlcalderon
Copy link

Great suggestion! Would you mind creating a PR @ehellman ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlcalderon @ehellman