Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet: check circuit version #856

Closed
wants to merge 36 commits into from

Conversation

eugypalu
Copy link
Contributor

@eugypalu eugypalu commented Aug 7, 2022

Resolves #855

Check that the version of the circuits saved in the wallet database matches the version saved on S3.
To check the version of the circuits, first download the file circuit-info.json, containing names and hashes of all circuits on S3, then compare the hashes in the file with the hashes of the circuits in the wallet database. If the hashes do not match, the circuits in the database are updated by downloading the new version from S3.
The algorithm used to calculate the hash is SHA256.

The circuit-info.json file is a JSON having the names of the circuits as keys and the hash of the relevant circuit as value. The file must be in the circuit folder of the bucket, currently there is only one circuit-info.json test file with empty hash, in the nightfallv3-testnet bucket.

Example of the circuit-info.json file:

{
    "deposit-abi": "",
    "deposit-program": "",
    "deposit-pk": "",
    "single_transfer-abi": "",
    "single_transfer-program": "",
    "single_transfer-pk": "",
    "double_transfer-abi": "",
    "double_transfer-program": "",
    "double_transfer-pk": "",
    "withdraw-abi": "",
    "withdraw-program": "",
    "withdraw-pk": ""
}

@druiz0992 druiz0992 added the DNM Do not merge label Aug 10, 2022
@druiz0992 druiz0992 closed this Aug 17, 2022
@druiz0992 druiz0992 reopened this Aug 17, 2022
@druiz0992
Copy link
Contributor

Closing PR. Implemented functionality in #861

@druiz0992 druiz0992 closed this Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM Do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet: check circuit version 
2 participants