-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet: check circuit version #856
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub.com/EYBlockchain/nightfall_3 into eugenio/check-block-correctness
Closing PR. Implemented functionality in #861 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #855
Check that the version of the circuits saved in the wallet database matches the version saved on S3.
To check the version of the circuits, first download the file circuit-info.json, containing names and hashes of all circuits on S3, then compare the hashes in the file with the hashes of the circuits in the wallet database. If the hashes do not match, the circuits in the database are updated by downloading the new version from S3.
The algorithm used to calculate the hash is SHA256.
The circuit-info.json file is a JSON having the names of the circuits as keys and the hash of the relevant circuit as value. The file must be in the circuit folder of the bucket, currently there is only one circuit-info.json test file with empty hash, in the nightfallv3-testnet bucket.
Example of the circuit-info.json file: