Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

challengeProofVerification unit test #1254

Closed

Conversation

eugypalu
Copy link
Contributor

@eugypalu eugypalu commented Nov 22, 2022

What does this implement/fix? Explain your changes.

Added unit tests of the challengeProofVerification function

Does this close any currently open issues?

close #1263

What commands can I run to test the change?

npm run unit-test-challenges

Any other comments?

Copy link
Contributor

@RogerTaule RogerTaule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test that reverts if the proof is actually valid?

@RogerTaule RogerTaule force-pushed the eugenio/challengeProofVerification-unit-test branch 2 times, most recently from f57782b to c839a98 Compare December 7, 2022 20:02
@eugypalu eugypalu force-pushed the eugenio/challengeProofVerification-unit-test branch from c839a98 to 3c1a89f Compare December 19, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

challengeProofVerification unit test
3 participants