From a88a48d7124391273ecdbe4134aff4d7f5db4431 Mon Sep 17 00:00:00 2001 From: John Wellbelove Date: Sun, 20 Oct 2024 09:13:02 +0100 Subject: [PATCH 1/3] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index d7c9c02b6..50c564c75 100644 --- a/README.md +++ b/README.md @@ -69,7 +69,7 @@ The library is intended for any compiler that supports C++98/03/11/14/17/20. - Checksums & hash functions - Variants (a type that can store many types in a type-safe interface) - Choice of asserts, exceptions, error handler or no checks on errors -- Unit tested (currently over 6480 tests), using VS2019, GCC 8.1.0, , GCC 9.3.0, Clang 9.0.0 & 10.0.0 +- Unit tested (currently over 9400 tests), using VS2022, GCC 12, Clang 14. - Many utilities for template support. - Easy to read and documented source. - Free support via email, GitHub and Slack From 09c78ee0b96cb74584e900fa9cd92fd66bb5422d Mon Sep 17 00:00:00 2001 From: David Hebbeker Date: Fri, 15 Nov 2024 12:10:53 +0100 Subject: [PATCH 2/3] Apply instructions for pull requests from Slack to new CONTRIBUTING guideline file. I copied the [message in Slack](https://etlcpp.slack.com/archives/C7SJ45VFB/p1729596737002559) from @jwellbelove into a new file for [contributing guidelines](https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors). This way a starting point for potential contributors is delivered next to the source code. --- CONTRIBUTING.md | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 000000000..8bd1ab2e7 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,9 @@ +# How to contribute + +If your are considering creating a pull request, please observe the following: + +- If you are adding or modifying a feature, add *new* unit tests that test that feature. +- If you are fixing a bug, add a unit test that *fails* before the bug fix is implemented. +- Do not initiate a pull request until all of the units tests pass. + +There is a project file for VS2022 for C++14, 17, 20, and bash scripts that run the tests for C++11, 14, 17, 20 under Linux with GCC and Clang. From b69b2e2851f22622585e6c96b919d921b60116b8 Mon Sep 17 00:00:00 2001 From: David Hebbeker Date: Fri, 15 Nov 2024 12:14:18 +0100 Subject: [PATCH 3/3] Added hint for the starting point for contributing commits. I derived this rule from https://github.com/ETLCPP/etl/issues/802#issuecomment-2323530862 --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8bd1ab2e7..56ce976d6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,5 +5,6 @@ If your are considering creating a pull request, please observe the following: - If you are adding or modifying a feature, add *new* unit tests that test that feature. - If you are fixing a bug, add a unit test that *fails* before the bug fix is implemented. - Do not initiate a pull request until all of the units tests pass. +- Branches should be based on the branch `master`. There is a project file for VS2022 for C++14, 17, 20, and bash scripts that run the tests for C++11, 14, 17, 20 under Linux with GCC and Clang.