Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Importing .ris file from CiteSource (Web Shiny) #183

Closed
TNRiley opened this issue Jul 9, 2024 · 2 comments
Closed

Re-Importing .ris file from CiteSource (Web Shiny) #183

TNRiley opened this issue Jul 9, 2024 · 2 comments
Assignees
Labels
Bug Something isn't working Shiny Application

Comments

@TNRiley
Copy link
Collaborator

TNRiley commented Jul 9, 2024

I can upload an .ris without being disconnected from the server, however, all visualizations and tables throw an error.

issues #177 and #178 are also re-import issues. Currently the CSV is working the best FYI

@TNRiley TNRiley added Bug Something isn't working Shiny Application labels Jul 9, 2024
@LukasWallrich LukasWallrich self-assigned this Jul 26, 2024
@LukasWallrich
Copy link
Collaborator

I now updated this, and it works for the visualisations and the reference table. It cannot work for the other table, as that requires the uploaded_df pre-deduplication.

I don't think that we actually ever need to go back to that. Instead, it might be cleaner to only work with deduplicated data (also related to the naming conversation we are having) - it seems to me that we can use the merged columns in the deduplicated data to do everything we currently do with the raw data - but that would require work on all the functions that currently rely on the full data. Otherwise, reimport will always be limited.

@TNRiley can you check if the other functionalities work for you as well after RIS import? Do you agree that we should get rid of references to the uploaded/original citations across the package after the deduplication? If so, can you maybe open a new issue for that?

@TNRiley
Copy link
Collaborator Author

TNRiley commented Jul 31, 2024

This makes sense, thanks @LukasWallrich. Those tables do rely on comparing dedup data with the original. I think we can try to rely solely on the deduplicated data. I'd have to look at those tables to see how we might do that. I can add a new issue on this as a future improvement.

@TNRiley TNRiley closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Shiny Application
Projects
None yet
Development

No branches or pull requests

2 participants