Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use integer parameters to identify each budget term #95

Closed
1 task
slevis-lmwg opened this issue Jun 6, 2024 · 0 comments · Fixed by #94
Closed
1 task

Use integer parameters to identify each budget term #95

slevis-lmwg opened this issue Jun 6, 2024 · 0 comments · Fixed by #94
Assignees
@mvertens

Comments

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Jun 6, 2024 •
edited
Loading

I think that we should use integer parameters to identify each budget term and bring clarity to this code. Instead of budget_terms( 1, nt) it should be
budget_terms(RUNOFF_WATER, nt) (or whatever it is).

Originally posted by @jedwards4b in #76 (comment)
mvertens pushed a commit to mvertens/mosart that referenced this issue Jun 7, 2024
addressed issue ESCOMP#95
c95417e
@mvertens mvertens linked a pull request Jun 7, 2024 that will close this issue
cism runoff will be now routed to ocn via mosart #94
Merged
5 tasks
@ekluzek ekluzek mentioned this issue Jun 20, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvertens mvertens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cism runoff will be now routed to ocn via mosart mvertens/mosart
2 participants
@mvertens @slevis-lmwg