Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch use of namelist attribute in failure testing in perl build-namelist tester #2673

Closed
ekluzek opened this issue Jul 31, 2024 · 1 comment · Fixed by #2829
Closed

Catch use of namelist attribute in failure testing in perl build-namelist tester #2673

ekluzek opened this issue Jul 31, 2024 · 1 comment · Fixed by #2829
Assignees
Labels
bfb bit-for-bit good first issue simple; good for first-time contributors testing additions or changes to tests

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Jul 31, 2024

Until #585 happens a little bit of error checking added to the failure and warning testing in ./build-namelist_test.pl could really help us with adding new tests. These tests set a hash, with options, namelst, phys, and XML variable names. If any of those are misspelled (with the misspelled namelist attribute namelst being particularly easy thing to miss) -- the test won't function correctly. But, just adding error checking to ensure the expected things are set would catch this for developers and make adding a new test much easier.

Also change namelst to namelist would also help as well.

@ekluzek ekluzek added tag: simple bfb testing additions or changes to tests next this should get some attention in the next week or two. Normally each Thursday SE meeting. and removed next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Jul 31, 2024
@samsrabin samsrabin added simple bfb bit-for-bit and removed simple bfb labels Aug 8, 2024
@mvdebolskiy
Copy link
Contributor

@ekluzek I haven't change the namelst. The error will give the spelling though.

@samsrabin samsrabin added good first issue simple; good for first-time contributors and removed simple labels Oct 3, 2024
@samsrabin samsrabin linked a pull request Oct 11, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit good first issue simple; good for first-time contributors testing additions or changes to tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants