Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure running test locally runs all tests (including storybook tests) #1163

Open
santilland opened this issue Jul 31, 2024 · 2 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@santilland
Copy link
Member

Currently running npm run tests:all does not run storybook e2e integration tests, this can be quite confusing as locally all tests can pass, but can fail when they run as action on github.

@santilland santilland added the enhancement New feature or request label Jul 31, 2024
@silvester-pari
Copy link
Collaborator

We originally said that running all storybook tests can take quite a while, so we opted for running only the tests for a changed element. But fine for me, if no specific element was changed, then all test should probably be run. @radupasparuga could you have a look into this?

@santilland
Copy link
Member Author

I think it is fine to run the tests in the github action only for changed things, but there is no easy method to running the same test suite locally while you are developing. So my proposal is that there can be one test script call to run all the tests, and the npm run tests:all seems like the appropriate for me to do that.
So my proposed goal is that you can somehow locally first check if things are working before pushing and needing to iterate with the test runs by pushing changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants