You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently running npm run tests:all does not run storybook e2e integration tests, this can be quite confusing as locally all tests can pass, but can fail when they run as action on github.
The text was updated successfully, but these errors were encountered:
We originally said that running all storybook tests can take quite a while, so we opted for running only the tests for a changed element. But fine for me, if no specific element was changed, then all test should probably be run. @radupasparuga could you have a look into this?
I think it is fine to run the tests in the github action only for changed things, but there is no easy method to running the same test suite locally while you are developing. So my proposal is that there can be one test script call to run all the tests, and the npm run tests:all seems like the appropriate for me to do that.
So my proposed goal is that you can somehow locally first check if things are working before pushing and needing to iterate with the test runs by pushing changes.
Currently running
npm run tests:all
does not run storybook e2e integration tests, this can be quite confusing as locally all tests can pass, but can fail when they run as action on github.The text was updated successfully, but these errors were encountered: