Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why Docker registry url asked when building #161

Open
orviz opened this issue Apr 6, 2022 · 2 comments
Open

Why Docker registry url asked when building #161

orviz opened this issue Apr 6, 2022 · 2 comments
Assignees
Labels
1.3.0 bug Something isn't working in staging Changes applied to the staging app

Comments

@orviz
Copy link
Contributor

orviz commented Apr 6, 2022

In the step 2 of the Pipeline as a Service, when defining a service that will be built from a Dockerfile, the field Docker registry URL (optional) is displayed. Don't remember why this is there, since in pushing to the registry is selected, this registry can be defined as part of the image name

@orviz orviz added the bug Something isn't working label Apr 6, 2022
@dianamariand92
Copy link
Collaborator

@orviz In the spec in services -> image -> registry we have the url parameter, that is why the Docker registry URL (optional) is displayed. If is not need it I can remove it.

@orviz
Copy link
Contributor Author

orviz commented Apr 12, 2022

@dianamariand92 I think we can remove this field yes. The registry URL is only needed when pulling or pushing, and at this point it's building. If as an additional step one wants to push the resultant image (enabling Would you like to push the Docker image to a registry?), the registry can be set as part of the Docker image value

@dianamariand92 dianamariand92 added the in staging Changes applied to the staging app label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.3.0 bug Something isn't working in staging Changes applied to the staging app
Projects
None yet
Development

No branches or pull requests

2 participants