Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend dateTimeFormatString to hours, minute and seconds #77

Open
earnaud opened this issue Nov 18, 2020 · 2 comments
Open

extend dateTimeFormatString to hours, minute and seconds #77

earnaud opened this issue Nov 18, 2020 · 2 comments

Comments

@earnaud
Copy link
Contributor

earnaud commented Nov 18, 2020

In one met use case, EAL sets as "categorical" an attribute containing hours at HH:MM:SS format.

According to EML documentation, this shall be set as an hour time format.

@clnsmth
Copy link
Contributor

clnsmth commented Nov 18, 2020

Hi @earnaud, template_table_attributes() guesses the column class beginning around line 223 (PR's to improve this code are welcome). If a column class is guessed incorrectly, the user should change it to the correct class. The "Date" class covers both dates and times and should work for HH:MM:SS.

@earnaud
Copy link
Contributor Author

earnaud commented Nov 19, 2020

I think MetaShARK will need to get the separator specified (although I could check by myself some of the most common ones). I will check your code to try to detect any bug or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants