Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDMC does not emit SquadronStartup event after launching the game #2286

Open
2 tasks done
CMDR-WDX opened this issue Aug 3, 2024 · 2 comments
Open
2 tasks done

EDMC does not emit SquadronStartup event after launching the game #2286

CMDR-WDX opened this issue Aug 3, 2024 · 2 comments
Labels
bug unconfirmed An unconfirmed bug
Milestone
5.13

Comments

@CMDR-WDX
Copy link

CMDR-WDX commented Aug 3, 2024 •
edited
Loading

Please complete the following information:

EDMC Version: 
 - 5.11.2+87f59a54.DIRTY

OS Details:
- Operating System: Linux 6.10.2-arch1-1
- Version: #1 SMP PREEMPT_DYNAMIC Sat, 27 Jul 2024 16:49:55 +0000
- Machine: x86_64
- Python Version: 3.12.4

Environment Details
- Detected Locale: en_GB
- Detected Encoding: UTF-8
- Journal Directory: /home/waldi/.steam/steam/steamapps/compatdata/359320/pfx/drive_c/users/steamuser/Saved Games/Frontier Developments/Elite Dangerous
- Game Version: 4.0.0.1807
- Game Build: r303387/r0 
- Using Odyssey: True
- Journal Dir Lockable: True

Describe the bug

The first time the player jumps into a game mode after the game has started, EDMC will sometimes fail to emit a SquadronStartup event. Subsequent launches into a game mode (going to menu and coming back) do correctly emit the event.

To Reproduce
Steps to reproduce the behavior:

Prerequisite: CMDR must be in a Squadron.

  1. Create a Plugin that makes use of the SquadronStartup event. I have provided an example plugin here
  2. Start up EDMC
  3. Start up the Game
  4. Go into any game mode, e.g. Open
  5. The SquadronStartup is not emitted. I have found that to be flaky. Sometimes it does, sometimes it doesn't
  6. Go back to main menu
  7. Go back into the game
  8. This time, the SquadronStartup will be emitted.

Expected behavior

The SquadronStartup event should be passed to the Plugin the first time the user jumps into a game mode

Screenshots
No screenshots, but a Repro video :)

edmc-squadronstartup-repro.mp4

Additional context

This issue does happen outside of Linux/Dirty EDMC Build. People on Windows with a stable build have notified me about incorrect Squadron Handling on my plugin which makes use of this event

No other plugin was loaded in the Repro video.

Please Confirm the Following...

Logs

Output of runing `edmarketconnector.sh` from the terminal 
➜  EDMarketConnector git:(main) edmarketconnector.sh
'fatal: not a git repository (or any of the parent directories): .git' doesn't look like a valid git short hash, forcing to None
2024-08-03 08:56:32.950 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.__main__:2079: Startup v5.11.2+UNKNOWN : Running on Python v3.12.4 (main, Jun  7 2024, 06:33:07) [GCC 14.1.1 20240522]
2024-08-03 08:56:32.953 UTC - INFO - 37076:125154798001024:37076 protocol.LinuxProtocolHandler.__init__:326: Web server listening on http://localhost:40067/auth
E:D Market Connector 5.11.2+UNKNOWN
2024-08-03 08:56:32.953 UTC - INFO - 37076:125154798001024:37076 killswitch.fetch_kill_switches:346: Attempting to fetch kill switches
2024-08-03 08:56:33.137 UTC - INFO - 37076:125154798001024:37076 killswitch.parse_kill_switches:419: Kill switches last updated 18 October 2021
2024-08-03 08:56:33.176 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.__main__:2208: Overriding tkinter default font to None at size 10
2024-08-03 08:56:33.177 UTC - INFO - 37076:125154798001024:37076 plug.Plugin.__init__:65: loading plugin "coriolis" from "/usr/lib/edmarketconnector/plugins/coriolis.py"
2024-08-03 08:56:33.179 UTC - INFO - 37076:125154798001024:37076 plug.Plugin.__init__:65: loading plugin "eddn" from "/usr/lib/edmarketconnector/plugins/eddn.py"
2024-08-03 08:56:33.193 UTC - INFO - 37076:125154798001024:37076 plug.Plugin.__init__:65: loading plugin "edsm" from "/usr/lib/edmarketconnector/plugins/edsm.py"
2024-08-03 08:56:33.204 UTC - INFO - 37076:125154798001024:37076 plug.Plugin.__init__:65: loading plugin "edsy" from "/usr/lib/edmarketconnector/plugins/edsy.py"
2024-08-03 08:56:33.205 UTC - INFO - 37076:125154798001024:37076 plug.Plugin.__init__:65: loading plugin "inara" from "/usr/lib/edmarketconnector/plugins/inara.py"
2024-08-03 08:56:33.214 UTC - INFO - 37076:125154798001024:37076 plug.Plugin.__init__:65: loading plugin "spansh_core" from "/usr/lib/edmarketconnector/plugins/spansh_core.py"
2024-08-03 08:56:33.215 UTC - INFO - 37076:125154798001024:37076 plug.Plugin.__init__:90: plugin EDMC-Massacres disabled
2024-08-03 08:56:33.215 UTC - INFO - 37076:125154798001024:37076 plug.Plugin.__init__:90: plugin EDMC_PvP_Bot disabled
2024-08-03 08:56:33.215 UTC - INFO - 37076:125154798001024:37076 plug.Plugin.__init__:90: plugin EDMC_PvP_Bot_old disabled
2024-08-03 08:56:33.216 UTC - INFO - 37076:125154798001024:37076 plug.Plugin.__init__:65: loading plugin "SquadronStartupMissingDemo" from "/home/waldi/.local/share/EDMarketConnector/plugins/SquadronStartupMissingDemo/load.py"
2024-08-03 08:56:33.236 UTC - INFO - 37076:125154798001024:37076 plugins.eddn.EDDNSender.sqlite_queue_v1:211: New 'eddn_queue-v1.db' created
2024-08-03 08:56:33.440 UTC - INFO - 37076:125154606712512:37083 update.Updater.worker:267: No new version available at this time
2024-08-03 08:56:33.465 UTC - INFO - 37076:125154798001024:37076 update.check_for_fdev_updates:71: FDEV ID file commodity.csv already up to date.
2024-08-03 08:56:33.659 UTC - INFO - 37076:125154798001024:37076 update.check_for_fdev_updates:71: FDEV ID file rare_commodity.csv already up to date.
2024-08-03 08:56:33.659 UTC - INFO - 37076:125154798001024:37076 update.Updater.check_for_updates:194: Tried to update bundle FDEV files but failed. Don't worry, this likely isn't important and can be ignored unless you run into other issues. If you're curious: [Errno 13] Permission denied: '/usr/lib/edmarketconnector/FDevIDs'
2024-08-03 08:56:33.744 UTC - INFO - 37076:125154798001024:37076 monitor.EDLogs.start:251: Polling Journal Folder: "/home/waldi/.steam/steam/steamapps/compatdata/359320/pfx/drive_c/users/steamuser/Saved Games/Frontier Developments/Elite Dangerous"
2024-08-03 08:56:33.744 UTC - INFO - 37076:125154798001024:37076 monitor.EDLogs.start:252: Start Journal File: "/home/waldi/.steam/steam/steamapps/compatdata/359320/pfx/drive_c/users/steamuser/Saved Games/Frontier Developments/Elite Dangerous/Journal.2024-08-03T105316.01.log"
2024-08-03 08:56:33.802 UTC - INFO - 37076:125154798001024:37076 update.check_for_fdev_updates:71: FDEV ID file commodity.csv already up to date.
2024-08-03 08:56:33.860 UTC - INFO - 37076:125154798001024:37076 update.check_for_fdev_updates:71: FDEV ID file rare_commodity.csv already up to date.
2024-08-03 08:56:50.604 UTC - INFO - 37076:125154596226752:37095 monitor.EDLogs.worker:466: New Journal File. Was "/home/waldi/.steam/steam/steamapps/compatdata/359320/pfx/drive_c/users/steamuser/Saved Games/Frontier Developments/Elite Dangerous/Journal.2024-08-03T105316.01.log", now "/home/waldi/.steam/steam/steamapps/compatdata/359320/pfx/drive_c/users/steamuser/Saved Games/Frontier Developments/Elite Dangerous/Journal.2024-08-03T105650.01.log"
2024-08-03 08:58:00.912 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.AppWindow.journal_event:1499: StartUp or LoadGame event
2024-08-03 08:58:00.912 UTC - INFO - 37076:125154798001024:37076 dashboard.Dashboard.start:93: Polling Dashboard "/home/waldi/.steam/steam/steamapps/compatdata/359320/pfx/drive_c/users/steamuser/Saved Games/Frontier Developments/Elite Dangerous"
2024-08-03 08:58:00.916 UTC - INFO - 37076:125154798001024:37076 <plugins>.SquadronStartupMissingDemo.load.journal_entry:55: RX LoadGame -> resetting state from False
2024-08-03 08:58:00.922 UTC - INFO - 37076:125154798001024:37076 <plugins>.SquadronStartupMissingDemo.load.journal_entry:66: RX Statistics. Was SquadronStartup present?: False
2024-08-03 08:58:18.785 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.AppWindow.journal_event:1573: Monitor: Enable WinSparkle automatic update checks
2024-08-03 08:58:24.076 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.AppWindow.journal_event:1499: StartUp or LoadGame event
2024-08-03 08:58:24.076 UTC - INFO - 37076:125154798001024:37076 dashboard.Dashboard.start:93: Polling Dashboard "/home/waldi/.steam/steam/steamapps/compatdata/359320/pfx/drive_c/users/steamuser/Saved Games/Frontier Developments/Elite Dangerous"
2024-08-03 08:58:24.079 UTC - INFO - 37076:125154798001024:37076 <plugins>.SquadronStartupMissingDemo.load.journal_entry:55: RX LoadGame -> resetting state from False
2024-08-03 08:58:25.100 UTC - INFO - 37076:125154798001024:37076 <plugins>.SquadronStartupMissingDemo.load.journal_entry:59: RX SquadronStartup -> set state from False to true
2024-08-03 08:58:26.160 UTC - INFO - 37076:125154798001024:37076 <plugins>.SquadronStartupMissingDemo.load.journal_entry:66: RX Statistics. Was SquadronStartup present?: True
^C2024-08-03 09:02:47.499 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.__main__:2330: Ctrl+C Detected, Attempting Clean Shutdown
2024-08-03 09:02:47.501 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.AppWindow.onexit:1873: Starting shutdown procedures...
2024-08-03 09:02:47.502 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.AppWindow.onexit:1876: Closing update checker...
2024-08-03 09:02:47.502 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.AppWindow.onexit:1883: Notifying plugins to stop...
2024-08-03 09:02:47.502 UTC - INFO - 37076:125154798001024:37076 plug.notify_stop:263: Asking plugin "EDDN" to stop...
2024-08-03 09:02:47.505 UTC - INFO - 37076:125154798001024:37076 plug.notify_stop:263: Asking plugin "EDSM" to stop...
2024-08-03 09:02:47.506 UTC - INFO - 37076:125154798001024:37076 plug.notify_stop:263: Asking plugin "Inara" to stop...
2024-08-03 09:02:47.507 UTC - INFO - 37076:125154798001024:37076 plug.notify_stop:263: Asking plugin "Spansh" to stop...
2024-08-03 09:02:47.507 UTC - INFO - 37076:125154798001024:37076 plug.notify_stop:269: Done
2024-08-03 09:02:47.507 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.AppWindow.onexit:1888: Unregistering hotkey manager...
2024-08-03 09:02:47.507 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.AppWindow.onexit:1892: Closing CAPI query thread...
2024-08-03 09:02:47.508 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.AppWindow.onexit:1896: Closing dashboard...
2024-08-03 09:02:47.508 UTC - INFO - 37076:125154749318848:37080 companion.Session.capi_query_worker:977: endpoint __EDMC_WORKER_SHUTDOWN, exiting...
2024-08-03 09:02:47.509 UTC - INFO - 37076:125154749318848:37080 companion.Session.capi_query_worker:1020: CAPI worker thread DONE
2024-08-03 09:02:47.509 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.AppWindow.onexit:1899: Closing journal monitor...
2024-08-03 09:02:47.510 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.AppWindow.onexit:1903: Closing protocol handler...
2024-08-03 09:02:47.510 UTC - INFO - 37076:125154798001024:37076 protocol.LinuxProtocolHandler.close:345: Shutting down httpd
2024-08-03 09:02:47.712 UTC - INFO - 37076:125154798001024:37076 protocol.LinuxProtocolHandler.close:348: Joining thread
2024-08-03 09:02:47.713 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.AppWindow.onexit:1906: Closing Frontier CAPI sessions...
2024-08-03 09:02:47.713 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.AppWindow.onexit:1910: Closing config...
2024-08-03 09:02:47.714 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.AppWindow.onexit:1913: Destroying app window...
2024-08-03 09:02:47.716 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.AppWindow.onexit:1916: Done.
2024-08-03 09:02:47.717 UTC - INFO - 37076:125154798001024:37076 EDMarketConnector.__main__:2332: Exiting
@CMDR-WDX CMDR-WDX added bug unconfirmed An unconfirmed bug labels Aug 3, 2024
@C1701D
Copy link
Member

C1701D commented Sep 14, 2024

Sorry that it took us some time to respond. Do you happen to have the two EDMC log files and also the corresponding journal file from when this issue occurs?

@Rixxan Rixxan added this to the 5.13 milestone Sep 25, 2024
@CMDR-WDX
Copy link
Author

Journal.2024-09-28T104430.01.log
EDMarketConnector-debug.log

Don't have the original log, but I reran the scenario from the video :)

Issue still persists, logs above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug unconfirmed An unconfirmed bug
Projects
None yet
Milestone
5.13
Development

No branches or pull requests
3 participants
@Rixxan @C1701D @CMDR-WDX