Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Checks: Better catch if WinSparkle isn't loaded/set up #1822

Open
Athanasius opened this issue Jan 20, 2023 · 0 comments
Open

Update Checks: Better catch if WinSparkle isn't loaded/set up #1822

Athanasius opened this issue Jan 20, 2023 · 0 comments
Labels
bug enhancement github_actions Pull requests that update Github_actions code Installer Related to the Windows installer
Milestone

Comments

@Athanasius
Copy link
Contributor

Due to the playing around with 64-bit builds I'd somehow managed to leave the "used for builds" version of the GH windows-build workflow using the 64-bit version of WinSparkle.dll, although we're still using 32-bit Python.

The symptom of this is:

  1. self.updater: Optional[ctypes.CDLL] = ctypes.cdll.WinSparkle fails, raising an exception.
  2. No notification is given to the user.
  3. No check for updates will work, or given an error, be it timed or manual.

So, we really need to be more paranoid in this code. There's a try/except already, but all the latter does is log the exception and then continue. We should be popping up an alert instead and after it's closed exit the program.

@Athanasius Athanasius added bug enhancement github_actions Pull requests that update Github_actions code Installer Related to the Windows installer labels Jan 20, 2023
@Rixxan Rixxan added this to the Pre-6.0 Changes milestone Aug 4, 2023
@Rixxan Rixxan modified the milestones: Pre-6.0 Changes, 5.12 Jun 10, 2024
@github-project-automation github-project-automation bot moved this to Low priority in Bug Triage Aug 28, 2024
@Rixxan Rixxan modified the milestones: 5.12, 5.13 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement github_actions Pull requests that update Github_actions code Installer Related to the Windows installer
Projects
Status: Low priority
Development

No branches or pull requests

2 participants