Improve treatment of RFCavity endpoints #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified the initial beam size in the IOTA lens benchmark example. - Added 2 benchmarks of 3D space charge for initial testing. - Add documentation for 2 benchmarks with space charge. - Add a benchmark example with space charge and periodic s-dependent focusing. - Added an s-dependent example using a Kurth beam without space charge. - Modified tolerance for IOTA lens benchmark example. Reduced tolerance to account for smaller initial beam size and improved preservation of invariants of motion. - Modified tolerances of space charge examples to allow CI tests to pass when space charge is not active. - Modified tolerance for space charge examples. These should fail unless space charge is turned on.
Selected numerical values for amr.n_cell, lattice.nslice, and geometry.prob_relative.
for more information, see https://pre-commit.ci
Not part of this PR.
Correction to initialization of efieldint.
ax3l
added
component: elements
qianglbl
approved these changes
May 1, 2024
ax3l
reviewed
May 1, 2024
Not part of this PR.
Co-authored-by: Axel Huebl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the treatment of RF cavity endpoints in the quantity
efieldintreturned by the functionRF_Efieldin RFCavity.H.This is a correction to the RF cavity field implementation that avoid spurious energy kicks associated with evaluation of the function
RF_Efieldat data values beyond the specified cavity endpoints. The indefinite integral of Ez should be a nonzero constant outside the field range of interest, to ensure continuity across the two endpoints.This has a small effect on the reference particle energy, and no modification of the benchmark analysis script analysis_rfcavity.py is needed.