Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a bug where centering coefficients used in Magentostatic solver… #5289

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Fixed a bug where centering coefficients used in Magentostatic solver… #5289

merged 3 commits into from
Sep 25, 2024

Conversation

clarkse
Copy link
Member

@clarkse clarkse commented Sep 18, 2024

… were not being initialized when doing an energy-conserving field gather.

@clarkse clarkse added bug Something isn't working bug: affects latest release Bug also exists in latest release version component: magnetostatic magneticstatic solver labels Sep 18, 2024
@clarkse clarkse mentioned this pull request Sep 18, 2024
Closed
@clarkse
Copy link
Member Author

clarkse commented Sep 18, 2024 •
edited
Loading

This should resolve issue #5242

@EZoni
Copy link
Member

EZoni commented Sep 19, 2024

To be rebased after #5296 is merged (will fix the clang-tidy-3D failure).

@roelof-groenewald roelof-groenewald linked an issue Sep 19, 2024 that may be closed by this pull request
B=0 field output in magnetostatic mode #5242
Closed
@roelof-groenewald
Copy link
Member

I agree this will fix the B = 0 issue with non-Eb runs but the introduction of non-zero div B (as described in #5175) will still be there. We can merge this though and I'll try to get the follow-up PR cleaned up and ready to go over the next week or two.

@clarkse
Copy link
Member Author

clarkse commented Sep 24, 2024

I agree this will fix the B = 0 issue with non-Eb runs but the introduction of non-zero div B (as described in #5175) will still be there. We can merge this though and I'll try to get the follow-up PR cleaned up and ready to go over the next week or two.

This is meant to be a quick patch for the issue until the larger PR is fully tested.

@roelof-groenewald
Copy link
Member

This looks good as an intermediate fix. @clarkse would you please rebase to development to sort out the merge conflict and we can merge this PR.

clarkse and others added 2 commits September 24, 2024 13:06
@clarkse
Fixed a bug where centering coefficients used in Magentostatic solver…
4535779 
… were not being initialized when doing an energy-conserving field gather.

Signed-off-by: S. Eric Clark <[email protected]>
@pre-commit-ci @clarkse
[pre-commit.ci] auto fixes from pre-commit.com hooks
c0bb670 
for more information, see https://pre-commit.ci
@clarkse
Pointer type passed into the magnetostatic solver for current is no l…
aa156bd 
…onger smart, so removed the call to get() to return the raw pointer.

Signed-off-by: S. Eric Clark <[email protected]>
@roelof-groenewald roelof-groenewald enabled auto-merge (squash) September 25, 2024 20:25
@roelof-groenewald roelof-groenewald merged commit e3e6ab8 into ECP-WarpX:development Sep 25, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roelof-groenewald roelof-groenewald roelof-groenewald approved these changes

@RemiLehe RemiLehe Awaiting requested review from RemiLehe

Assignees

@roelof-groenewald roelof-groenewald

Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: magnetostatic magneticstatic solver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

B=0 field output in magnetostatic mode
3 participants
@clarkse @EZoni @roelof-groenewald