Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTest follow-up: add single-precision tests #5205

Open
EZoni opened this issue Sep 3, 2024 · 1 comment
Open

CTest follow-up: add single-precision tests #5205

EZoni opened this issue Sep 3, 2024 · 1 comment
Assignees
Labels
component: tests Tests and CI

Comments

@EZoni
Copy link
Member

EZoni commented Sep 3, 2024

Follow-up on #5068. Run all (if not, a subset of) tests in single-precision, compare against existing double-precision checksum files with a larger tolerance.

@EZoni EZoni added the component: tests Tests and CI label Sep 3, 2024
@EZoni EZoni self-assigned this Sep 3, 2024
@EZoni EZoni mentioned this issue Sep 3, 2024
21 tasks
@ax3l
Copy link
Member

ax3l commented Sep 4, 2024

To generalize the analysis scripts, we could change the APIs of the tolerance argument to the checksum API, and pass a dictionary (double and single as keys) for the tolerances. Or have two arguments, one double tolerance one float (with a dictionary, we keep it open to have other types later, but I do not think this is timely.)

Inside the checksum API, we could do a test for WarpX config used or type of a data file entry read to determine if something was a SP or DP run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tests Tests and CI
Projects
None yet
Development

No branches or pull requests

2 participants