Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostics: Time-Averaged Fields #5165

Closed
ax3l opened this issue Aug 22, 2024 · 3 comments · Fixed by #5285
Closed

Diagnostics: Time-Averaged Fields #5165

ax3l opened this issue Aug 22, 2024 · 3 comments · Fixed by #5285
Labels
component: diagnostics all types of outputs

Comments

@ax3l
Copy link
Member

ax3l commented Aug 22, 2024

For LPI simulations, we would like a diagnostics that time-averages (over N subsequent steps) the output fields.

This is relatively easy to implement if we enforce the assumption that the output period P is greater than the averaging period N. For many simulations, that is sufficient and true.
@ax3l ax3l added the component: diagnostics all types of outputs label Aug 22, 2024
@ax3l ax3l changed the title Time-Averaged Fields Diagnostics: Time-Averaged Fields Aug 22, 2024
@RevathiJambunathan
Copy link
Member

@ax3l why would we need to enforce this assumption?
I would think we could do it more generally?

@ax3l
Copy link
Member Author

ax3l commented Aug 29, 2024 •
edited
Loading

@RevathiJambunathan because otherwise we will have run-away memory consumption (and more book keeping).

As an update, we clarified in the last meetings (AMP and KISMET) with the current sciences cases in our projects that this assumption works very well for everyone that requested this feature.

@RevathiJambunathan
Copy link
Member

But we can have a running average being written out often - it will not consume more memory. We can chat during the hackathon

@n01r n01r mentioned this issue Sep 18, 2024
Merged
4 tasks
EZoni added a commit that referenced this issue Oct 24, 2024
@n01r @RevathiJambunathan
@pre-commit-ci @EZoni
Add Time-Averaged Field Diagnostics (#5285)
a25faff 
This PR adds time-averaged field diagnostics to the WarpX output.

To-do:
- [x] code
- [x] docs
- [x] tests
- [x] example

Follow-up PRs:
- meta-data
- make compatible with adaptive time stepping

This PR is based on work performed during the *2024 WarpX Refactoring
Hackathon* and was created together with @RevathiJambunathan.

Successfully merging this pull request may close #5165.

---------

Co-authored-by: RevathiJambunathan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Edoardo Zoni <[email protected]>
Co-authored-by: Edoardo Zoni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: diagnostics all types of outputs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Time-Averaged Field Diagnostics RevathiJambunathan/WarpX
2 participants
@ax3l @RevathiJambunathan