Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depo-Curation - Functionality to prevent missing EFOs #234

Open
sajo-ebi opened this issue Jul 23, 2024 · 3 comments
Open

Depo-Curation - Functionality to prevent missing EFOs #234

sajo-ebi opened this issue Jul 23, 2024 · 3 comments
Assignees
Labels

Comments

@sajo-ebi
Copy link
Collaborator

We recently faced issue with Data release where DR failed due to missing EFO's for some studies . This was accidently missed in Depo Curation while editing Backman Submission to update some EFO's . Curators felt that the studies tab in Submission details page currently doesn't have search filter & it is difficult to navigate to the specific GCST scrolling through pages , Hence they need search filter on the studies page to allow them to update the study directly through UI without needing to do bulk upload for few studies in large submissions.

Also we have huge impact in data release if Efo's are missing , the Data release fails at Solr QC step & we have to start DR from scratch to fix the issue . To avoid this we must add validation in Depo CUration to not enable Allow import button unless EFO are added for all studies , this will save us enormous amount of time rerunning DR & optimize the process

@sajo-ebi sajo-ebi self-assigned this Jul 23, 2024
@ljwh2
Copy link

ljwh2 commented Jul 24, 2024

A third feature that would help to avoid this is to be able to download currently assigned trait & EFO terms for a submission @earlEBI could you please add the details here, or are they covered by this ticket?

@earlEBI
Copy link

earlEBI commented Jul 24, 2024

@ljwh2 I think it is covered there except to just double-check, will Mongo always match Oracle if the obsolete EFO script has auto-updated an EFO post-curation? Does the download have to specifically come from the live data?

@ljwh2 ljwh2 added the Epic label Jul 24, 2024
@ljwh2
Copy link

ljwh2 commented Jul 25, 2024

@earlEBI Sajo confirmed EFO update runs on Mongo only then it is synced with Oracle

@ljwh2 ljwh2 changed the title Depo-Curation - Add Search functionality to studies page in Submission detail & Add validation to ensure EFO traits are added before import Depo-Curation - Functionality to prevent missing EFOs Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants