add ships and ship building #62
Conversation
✅ Deploy Preview for tangerine-frangipane-73560e ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
|
||
| export const buildShip = (system:System) => { | ||
| console.log('help') | ||
| setTimeout(function(){system.hangar.push(ship1); console.log(system.hangar)}, ship1.buildTime*1000) |
There was a problem hiding this comment.
Hi Shirley, I'm not seeing the ship added to the system's array when I click this button. It's throwing this error generate-sector.ts:32 Uncaught TypeError: Cannot add property 0, object is not extensible
There was a problem hiding this comment.
P.S the UI will update if there's something in the hangar. Or at least it SHOULD, we haven't tested that yet
There was a problem hiding this comment.
Look into Object.freeze and checking to find out when the array/object in question is frozen or not. It might have something to do with set time out having some sort of side effect on the object frozen status.
There was a problem hiding this comment.
@DylanBozarth @Sjazfrey Do we know if this is ready to merge?
#44