Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight all layer changes #821

Open
derrik-fleming opened this issue Jul 3, 2024 · 1 comment
Open

Highlight all layer changes #821

derrik-fleming opened this issue Jul 3, 2024 · 1 comment
Labels
bug Something isn't working FW For issues with the keyboard's behavior

Comments

@derrik-fleming
Copy link

Describe the bug
I recently enabled "Highlight layer changing" I noticed that with my config the highlight effect only happens when I change to a layer from my base layer. But if I change to a layer from another non-base layer it doesn't highlight that layer change.

To Reproduce
A bit of context around my set up, I have 4 layers, that I use primarily, 2 are accessible from the base layer and the 4th is only accessible from either of the 2 non-base layers.

So on my base layer I have:

  • a key that allows me to get to Layer 2 by press and hold
  • a key that allows me to get to Layer 3 by press and hold

On Layer 2:

  • a key that allows me to get to Layer 4 by press and hold (its the same key that's use to get to Layer 3 in base)

On Layer 3:

  • a key that allows me to get to Layer 4 by press and hold (it's the same key that's used to get to Layer 2 in base layer)

Steps to reproduce the behavior:

  1. Create a setup up similar to the one explained above
  2. Shift to a non-base layer that has a Layer Shift-ing key
  3. Shift to the other layer from the non-base layer
  4. Observe no layer shifting highlight

Expected behavior
Any layer shifting would produce the highlight effect

Screenshots
image
image
image
image

Desktop (please complete the following information):

  • OS: MacOS
  • Bazecor Version: 1.4.0-rc.6 (1.4.0-rc.6)

Additional context
Add any other context about the problem here.

@derrik-fleming derrik-fleming added the bug Something isn't working label Jul 3, 2024
@derrik-fleming derrik-fleming changed the title Highlight layer changing from base layer only Highlight all layer changes Jul 3, 2024
@alexpargon alexpargon added the FW For issues with the keyboard's behavior label Jul 26, 2024
@MiquelDygma
Copy link

MiquelDygma commented Oct 16, 2024

Thank you @derrik-fleming

Sorry for the late reply.

We added this to the Firmware bugfixing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FW For issues with the keyboard's behavior
Projects
None yet
Development

No branches or pull requests

3 participants