From 913f2db3d7bcc86a63141c8ab2fc80cca71305f0 Mon Sep 17 00:00:00 2001 From: neeleshmalpani Date: Sun, 25 Feb 2024 19:39:05 +0530 Subject: [PATCH] feat: Added branchId & directoryId param in list language translations --- .../client/stringtranslations/StringTranslationsApi.java | 6 +++++- .../stringtranslations/StringTranslationsApiTest.java | 6 +++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/crowdin/client/stringtranslations/StringTranslationsApi.java b/src/main/java/com/crowdin/client/stringtranslations/StringTranslationsApi.java index 240e8eecf..4cfd810c3 100644 --- a/src/main/java/com/crowdin/client/stringtranslations/StringTranslationsApi.java +++ b/src/main/java/com/crowdin/client/stringtranslations/StringTranslationsApi.java @@ -109,6 +109,8 @@ public void removeApproval(Long projectId, Long approvalId) throws HttpException * @param stringIds filter translations by stringIds * @param labelIds filter translations by labelIds * @param fileId filter translations by file identifier + * @param branchId filter translations by branchId + * @param directoryId filter translations by directoryId * @param croql filter translations by croql * @param denormalizePlaceholders enable denormalize placeholders * @param limit maximum number of items to retrieve (default 25) @@ -119,12 +121,14 @@ public void removeApproval(Long projectId, Long approvalId) throws HttpException *
  • Enterprise API Documentation
  • * */ - public ResponseList listLanguageTranslations(Long projectId, String languageId, String stringIds, String labelIds, Long fileId, String croql, Integer denormalizePlaceholders, Integer limit, Integer offset) throws HttpException, HttpBadRequestException { + public ResponseList listLanguageTranslations(Long projectId, String languageId, String stringIds, String labelIds, Long fileId, Long branchId, Long directoryId, String croql, Integer denormalizePlaceholders, Integer limit, Integer offset) throws HttpException, HttpBadRequestException { String builtUrl = String.format("%s/projects/%d/languages/%s/translations", this.url, projectId, languageId); Map> queryParams = HttpRequestConfig.buildUrlParams( "stringIds", Optional.ofNullable(stringIds), "labelIds", Optional.ofNullable(labelIds), "fileId", Optional.ofNullable(fileId), + "branchId", Optional.ofNullable(branchId), + "directoryId", Optional.ofNullable(directoryId), "croql", Optional.ofNullable(croql), "denormalizePlaceholders", Optional.ofNullable(denormalizePlaceholders), "limit", Optional.ofNullable(limit), diff --git a/src/test/java/com/crowdin/client/stringtranslations/StringTranslationsApiTest.java b/src/test/java/com/crowdin/client/stringtranslations/StringTranslationsApiTest.java index d17981bc5..e85325169 100644 --- a/src/test/java/com/crowdin/client/stringtranslations/StringTranslationsApiTest.java +++ b/src/test/java/com/crowdin/client/stringtranslations/StringTranslationsApiTest.java @@ -93,7 +93,7 @@ public void removeApprovalTest() { @Test public void listLanguageTranslationsPlainTest() { - ResponseList languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(projectId, language, null, null, null, null, null, null, null); + ResponseList languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(projectId, language, null, null, null,null,null, null, null, null, null); assertEquals(1, languageTranslationsList.getData().size()); assertTrue(languageTranslationsList.getData().get(0).getData() instanceof PlainLanguageTranslations, "Wrong return type, must be PlainLanguageTranslations"); assertEquals(stringId, ((PlainLanguageTranslations) languageTranslationsList.getData().get(0).getData()).getStringId()); @@ -101,7 +101,7 @@ public void listLanguageTranslationsPlainTest() { @Test public void listLanguageTranslationsPluralTest() { - ResponseList languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(secondProjectId, language, null, null, null, null, null, null, null); + ResponseList languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(secondProjectId, language, null, null, null, null,null,null, null, null, null); assertEquals(1, languageTranslationsList.getData().size()); assertTrue(languageTranslationsList.getData().get(0).getData() instanceof PluralLanguageTranslations, "Wrong return type, must be PluralLanguageTranslations"); assertEquals(stringId, ((PluralLanguageTranslations) languageTranslationsList.getData().get(0).getData()).getStringId()); @@ -109,7 +109,7 @@ public void listLanguageTranslationsPluralTest() { @Test public void listLanguageTranslationsICUTest() { - ResponseList languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(thirdProjectId, language, null, null, null, null, null, null, null); + ResponseList languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(thirdProjectId, language, null, null, null, null, null, null, null, null, null); assertEquals(1, languageTranslationsList.getData().size()); assertTrue(languageTranslationsList.getData().get(0).getData() instanceof ICULanguageTranslations, "Wrong return type, must be ICULanguageTranslations"); assertEquals(stringId, ((ICULanguageTranslations) languageTranslationsList.getData().get(0).getData()).getStringId());