Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS SDK Upgrade to 2.1.2 #5

Open
andrekovac opened this issue Jan 13, 2021 · 3 comments · May be fixed by #7
Open

iOS SDK Upgrade to 2.1.2 #5

andrekovac opened this issue Jan 13, 2021 · 3 comments · May be fixed by #7

Comments

@andrekovac
Copy link
Contributor

andrekovac commented Jan 13, 2021

iOS SDK Changelog: https://github.com/helpscout/beacon-ios-sdk/blob/master/CHANGELOG.md


@JonasWho reported: iOS project build error after updating the pod version of 'Beacon'

Screenshot 2021-01-06 at 14 53 20

Originally posted by @andrekovac in #4 (comment)

@andrekovac
Copy link
Contributor Author

andrekovac commented Jan 13, 2021

from iOS SDK this line might be useful:

SwiftUI previews now work as we distribute Beacon 2.1.0 as an XCFramework. Issue 112

See this comment as well: https://github.com/helpscout/beacon-ios-sdk/issues/112#issuecomment-724197861

@andrekovac andrekovac changed the title iOS SDK Upgrade iOS SDK Upgrade to 2.1.2 Jan 13, 2021
@andrekovac
Copy link
Contributor Author

andrekovac commented Jan 15, 2021

Notes after attempting the upgrade, but running into the error stated in the issue description:

Error

Right above the error in the screenshot of the issue description ( the one which starts with CompileC ....) it says:

/.../node_modules/react-native-helpscout-beacon/ios/HelpscoutBeacon.m:2:9: fatal error: 'Beacon.h' file not found
#import "Beacon.h"
        ^~~~~~~~~~
1 error generated.

Unsuccessful attempts

use_frameworks! in Podfile of target project

The HelpScout Beacon iOS SDK Cocoapods instructions state that use_frameworks! (which declares that you want to use dynamic frameworks, instead of static libraries) has to be added to the Podfile. This however conflicts with use_native_modules! which is added for auto-linking react-native packages.

As a solution to this problem this SO answer can be used. This however didn't solve the overall issue.

@andrekovac andrekovac linked a pull request Jan 15, 2021 that will close this issue
@andrekovac
Copy link
Contributor Author

Please continue work on this issue by adding to PR #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant