Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Line of Sight #16

Open
supsm opened this issue Dec 28, 2021 · 4 comments
Open

Feature Request: Line of Sight #16

supsm opened this issue Dec 28, 2021 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@supsm
Copy link

supsm commented Dec 28, 2021

Could we have a config option that checks are hidden based on line of sight instead of if they are surrounded by air? It would make for a more accurate detection, at the cost of performance. Here are some scenarios where it would be better:

  • Say for whatever reason that the server admin is using engine mode 1 (in my case it was because torches were causing too much lag). Then, xrayers would still be able to find exposed ores, such as in caves
  • If they are using engine mode 2, they could only mine for exposed ores (I believe baritone has an option for this)

Simple Anti-Xray uses this method, and it has been fine in my previous server without causing a significant amount of lag.

@DrexHD DrexHD added enhancement New feature or request help wanted Extra attention is needed labels Dec 29, 2021
@Splarkszter
Copy link

Torches cause lag?

I do have a lag sensitive server that i will be using with friends. It really was this mod the issue about torches??

(I noticed this is 1 year old... so i don't know if that performance issue persists)

@DrexHD
Copy link
Owner

DrexHD commented Apr 11, 2023

If you run this mod with the default config, it won't cause any noticeable performance decrease.

@supsm
Copy link
Author

supsm commented Apr 12, 2023

Torches cause rendering lag when there are a ton of them, which would be the case if torches are added to the list (as it would be replacing a lot of stone with torches). The default config does not have this, so unless you explicitly changed the config to include torches, it shouldn't be an issue.

@NetheriteBowl
Copy link

It has to be recognised that Simple Anti X-Ray 's approach is rarely lagging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants