Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trackpad unusable for scrolling and zooming (MacOS) #599

Open
hmoazed opened this issue Apr 8, 2023 · 6 comments · May be fixed by #834
Open

Trackpad unusable for scrolling and zooming (MacOS) #599

hmoazed opened this issue Apr 8, 2023 · 6 comments · May be fixed by #834

Comments

@hmoazed
Copy link

hmoazed commented Apr 8, 2023

Using the trackpad to scroll through the captured data inadvertently causes zooming in and out, and vise-versa.
This is because the trackpad gesture for scrolling horizontally (two finger left or right swipe) also as a side effect triggers the gesture to zoom in and and out (two finger up or down swipe, which on MacOS trackpad is not zooming but moving up and down, zooming is accomplished using the pinch gesture).
To correct this, we'd need to add "Trackpad / Mouse" toggle, and when in Trackpad mode, the pinch gesture is used to zoom instead of the up/down gesture.
This is a very common issue in cross platform CAD programs (EasyEDA just fixed this recently, as well as Fusion 360).
@ddavidebor
Copy link

Encountered the same issue, very annoying!

@dreamsource-tai
Copy link
Collaborator

@hmoazed
@ddavidebor
Ok,We will check this issue. Thank you!

@dreamsource-tai
Copy link
Collaborator

@hmoazed
@ddavidebor
We fixed this issue, you can try the new version by the way compile from code source.

@M4tsuri
Copy link

M4tsuri commented Jan 23, 2024 •
edited
Loading

This issue still exists on dev-1.3.2 288a459. Moreover, scaling by scrolling on touchpad is basically unusable since its too sensitive to operate and there is no option to adjust it.

@ddavidebor
Copy link

Hi, sorry, but this took too long, we will buy from Saleae in the future

@FearlessArmada
Copy link

I found a hacky fix, in the file DSView/pv/view/viewport.cpp at line 1360 you have to divide the values by something like 16 or 32, like this:

double divisor_zoom = 16; // factor by which it divides
double zoom_scale = delta / 80 / divisor_zoom;

if (ABS_VAL(delta) <= 80){
    zoom_scale = delta > 0 ? 1.5 / divisor_zoom : -1.5 / divisor_zoom;
}

This should probably be made into some kind of setting that users can adjust.

FearlessArmada added a commit to FearlessArmada/DSView that referenced this issue Jan 1, 2025
@FearlessArmada
Add a Scroll Speed option and remove the temporary divisor_zoom fix. …
bfb578c 
…This is a QoL feature for laptop users and a fix for #DreamSourceLabgh-599
@FearlessArmada FearlessArmada linked a pull request Jan 1, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a ScrollSpeed option FearlessArmada/DSView
5 participants
@hmoazed @ddavidebor @M4tsuri @dreamsource-tai @FearlessArmada