From b2e6755e715c43bf64b1ec70b47a70b4778ab41d Mon Sep 17 00:00:00 2001 From: "Malte S. Kurz" Date: Mon, 25 Dec 2023 14:22:29 +0100 Subject: [PATCH 1/2] pin ubuntu version for python 3.6 & 3.7 --- .github/workflows/pytest.yml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pytest.yml b/.github/workflows/pytest.yml index 8158e80..3b7e251 100644 --- a/.github/workflows/pytest.yml +++ b/.github/workflows/pytest.yml @@ -16,15 +16,16 @@ on: jobs: build: - runs-on: ubuntu-latest + runs-on: ${{ matrix.config.os }} + strategy: matrix: config: - - {python-version: '3.6', doubleml-version: 'release'} - - {python-version: '3.7', doubleml-version: 'release'} - - {python-version: '3.8', doubleml-version: 'release'} - - {python-version: '3.8', doubleml-version: 'dev'} - - {python-version: '3.9', doubleml-version: 'release'} + - {os: 'ubuntu-20.04', python-version: '3.6', doubleml-version: 'release'} + - {os: 'ubuntu-20.04', python-version: '3.7', doubleml-version: 'release'} + - {os: 'ubuntu-latest', python-version: '3.8', doubleml-version: 'release'} + - {os: 'ubuntu-latest', python-version: '3.8', doubleml-version: 'dev'} + - {os: 'ubuntu-latest', python-version: '3.9', doubleml-version: 'release'} steps: - uses: actions/checkout@v3 From 7bd93612424e7824747161bb7038c99fcd87bc07 Mon Sep 17 00:00:00 2001 From: "Malte S. Kurz" Date: Mon, 25 Dec 2023 14:24:48 +0100 Subject: [PATCH 2/2] use named function arguments when calling the init of the superclass --- doubleml_serverless/double_ml_data_aws.py | 24 +++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/doubleml_serverless/double_ml_data_aws.py b/doubleml_serverless/double_ml_data_aws.py index 105e16a..00c68a0 100644 --- a/doubleml_serverless/double_ml_data_aws.py +++ b/doubleml_serverless/double_ml_data_aws.py @@ -14,12 +14,12 @@ def __init__(self, x_cols=None, z_cols=None, use_other_treat_as_covariate=True): - super().__init__(data, - y_col, - d_cols, - x_cols, - z_cols, - use_other_treat_as_covariate) + super().__init__(data=data, + y_col=y_col, + d_cols=d_cols, + x_cols=x_cols, + z_cols=z_cols, + use_other_treat_as_covariate=use_other_treat_as_covariate) self._bucket = bucket self._file_ending = os.path.splitext(file_key)[1] assert self._file_ending in ['.csv'] @@ -80,12 +80,12 @@ def __init__(self, x_cols=None, z_cols=None, use_other_treat_as_covariate=True): - super().__init__(data, - y_col, - d_cols, - x_cols, - z_cols, - use_other_treat_as_covariate) + super().__init__(data=data, + y_col=y_col, + d_cols=d_cols, + x_cols=x_cols, + z_cols=z_cols, + use_other_treat_as_covariate=use_other_treat_as_covariate) self._data_json = data.to_json(orient="columns") @property