Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] A config option to disable automatic script reloading #27

Open
Saereth opened this issue Feb 28, 2017 · 2 comments
Open

[Suggestion] A config option to disable automatic script reloading #27

Saereth opened this issue Feb 28, 2017 · 2 comments
Assignees

Comments

@Saereth
Copy link

Saereth commented Feb 28, 2017

In large packs and packs with hundreds or thousands of lines of mt scripts reloading everytime you hit ok becomes a monumental waste of time. It would be good if there were a config option to disable this and allow people to manually reload when they are done adding several recipes.

If you like the idea I'd be willing to contribute a PR for it sometime this week as well.

@Claycorp
Copy link
Member

I totally get why you would want to turn it off. Perhaps even like a shift+click (if possible) to not reload.

I'm not sure when Dries will be available to add this, so if this issue is still open by the time you get to it feel free to submit a PR.

@dries007
Copy link
Member

dries007 commented Feb 28, 2017

I think a checkbox (by default on, but once you turn it off it says off while to gui is open) that enables reload would be a good option. That or a reload button. I don't have the time to do it myself right now, so a PR would be appreciated. (If you do, do make one for 1.11 and 1.10 please. 1.7.10 is optional at this point)

(I replied by mail to this, and it didn't work 😢 )

@dries007 dries007 self-assigned this Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants