Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR Code scanning add button with a supported data for a db entry embedded in the QR code. #66

Open
NonaSuomy opened this issue Aug 12, 2023 · 2 comments
Labels
Feature Request New feature or request

Comments

@NonaSuomy
Copy link

NonaSuomy commented Aug 12, 2023

OP Ref: #10

I haven't tested if you can already do this with the edit button or not. Could you add an add button to the scan page where you can click add for a QR code that is not in your database? Which it will then fill in all the values for you from whatever the manufacturer sets. Say the producers of the filament wanted to support Spoolman and had premade Spoolman QR codes on their spools for instance that you just bought or a friend/reseller sent you a spool with the Spoolman QR tag on it.

Can you add another action button on the spool list that sets the spool id via a call to Moonraker?

Moved to: #72

@NonaSuomy NonaSuomy changed the title QR Code scanning and action button beside spool to set spool ID via moonraker/ip QR Code scanning add button and action button beside spool to set spool ID via moonraker/ip Aug 12, 2023
@NonaSuomy NonaSuomy changed the title QR Code scanning add button and action button beside spool to set spool ID via moonraker/ip QR Code scanning add button and action button beside spool to set spool ID via Moonraker/IP Aug 12, 2023
@Donkie
Copy link
Owner

Donkie commented Aug 13, 2023

The current QR codes contains no data other than the spool ID. To do what you ask, it would have to be extended to support that, which could be done I guess, but is not what I had in mind from the beginning.

Spoolman has no knowledge of Moonraker's existence, which is how I want it to remain. The embedded client in Spoolman was never intended to be the main interface for Spoolman. The intention was always that the frontends (Mainsail etc) would do the actual client. They know about Moonraker, and can thus easily set the spool and so on.

@NonaSuomy
Copy link
Author

NonaSuomy commented Aug 13, 2023

The current QR codes contains no data other than the spool ID. To do what you ask, it would have to be extended to support that, which could be done I guess, but is not what I had in mind from the beginning.

Makes sense. I think this should be extended to enable this before things get too popular. Would make spool entry leaps and bounds easier to catalog.

I'm going to change the title to only this for a feature request then move the second part to another one.

Moved second question to: #72

Thank you.

@NonaSuomy NonaSuomy changed the title QR Code scanning add button and action button beside spool to set spool ID via Moonraker/IP QR Code scanning add button with a supported data for a db entry embedded in the QR code. Aug 13, 2023
@Donkie Donkie added the Feature Request New feature or request label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants