-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skull indices are used instead of new layer labels #25
Comments
The segmentation in SimNibs is now done using Charm instead of headreco. Therefore, the labels of every tissue are different. This is fixed and the code is also made more robust, so less hardcoded label values.
Fix has been made for this issue. Pull request (#27) is created, so code can be tested first. |
The current master still has quite a few hardcoded values, see e.g., this block. I am currently working on a solution. This partially arises from how the specification is designed: parameters.layer_labels specifies the layers that are to-be-modelled, and this specification is sequential. If we would specify an additional csf field in the end, it may interfere with the more global water layer that we would like to model. Beyond the obvious solution of requiring the standard layer specifiation, my current solution relies on an additional config field "seg_labels":
If this field is absent, I throw a warning that hardcoded values are being used. I now also export niftis of density and soundspeed, as those provide critical checks of whether everything has been properly implemented before running acoustics & heating. Included in commit 3195d93 |
When the switch to charm was made in the previous major revision, the pipeline was adjusted to accept skull indices instead of the new layer labels to save time.
This can lead (and has led) to issues by using the incorrect layer labels.
To prevent further confusion in the future, I suggest to adjust all the code to accept the updated layer labels from
charm
instead of the layer indices.The text was updated successfully, but these errors were encountered: