Qual: Fix phan/phpstan notices 💊 #31259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this change cause error 5203d99 |
mdeweerd
force-pushed
the
fix/phan20241002
branch
3 times, most recently
from
34db4d4
to
517a963
Compare
Thanks, I reverted it to static. |
|
I added an exception in phpstan.neon.dist - test_buttons give 'true' to confirm, not an array - this is pre-existing, so ignored for the sake of fixing ci. |
# Qual: Fix phan/phpstan notices Fix notices by adjusting phpdoc
mdeweerd
force-pushed
the
fix/phan20241002
branch
from
517a963
to
853ceed
Compare
|
@eldy 6his fixes CI. |
mdeweerd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qual: Fix phan/phpstan notices
Fix notices by adjusting phpdoc