Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : Use contract line for api contracts #31243

Open
wants to merge 3 commits into
base: 17.0
Choose a base branch
from

Conversation

atm-irvine
Copy link
Contributor

@atm-irvine atm-irvine commented Oct 3, 2024

Introduced a new ContratLigne instance ($contractLine) in the Contracts class to manage contract lines more efficiently.

Replaced direct calls to the contract object for contract line operations (addline, updateline, deleteline) with methods from ContratLigne (insert, update, delete, fetch, active_line, close_line).

Added new delete function in ContratLigne class

@eldy eldy added PR no feature/refacto into freezed/released branch PR can't be accepted because it's a feature change or refactoring pushed into a stable frozen branch PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do) and removed PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do) labels Oct 3, 2024
@eldy
Copy link
Member

eldy commented Oct 4, 2024

Pr must be pushed into develop branch.

@atm-irvine
Copy link
Contributor Author

@eldy New PR : #31267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR no feature/refacto into freezed/released branch PR can't be accepted because it's a feature change or refactoring pushed into a stable frozen branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants