Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got vi window asking to fill out commit message during 'con topics submit' #112

Open
zanerock opened this issue Apr 13, 2014 · 2 comments
Open

Comments

@zanerock
Copy link
Member

If a topic is cleared for submit, no further information should be required of the user.

The PR message seems to be correct and NOT the value from the form, so I'm not sure where this came from. Why was there a commit at all? Best guess: there were uncommitted changes (though my memory of the events was that this was not the case, but clearly something went wrong). Or, it's just a straightforward logic bug.

@zanerock
Copy link
Member Author

Observed the repo had two topic branches... may have also had to do with possible 'start' from a topic branch... not sure what the cause, maybe just flashback to manual git and just jumped back to master?

@zanerock
Copy link
Member Author

Another bit of evidence... or a different related or entirely unrelated bug. Two things to notice. First, the 'con -s' default resource is working, but then gets lost. Second, the submit gives unfriendly feedback. May need to break out new bugs based on findings.

user@git-convey-wkst:~/playground/dogfoodsoftware.com/conveyor/workflow> con publish
Published topic '108-improve-con-status'.
user@git-convey-wkst:~/playground/dogfoodsoftware.com/conveyor/workflow> con status
# On branch topics-108-improve-con-status
nothing to commit, working directory clean
Connected to GitHub as: zanerock
user@git-convey-wkst:~/playground/dogfoodsoftware.com/conveyor/workflow> con submit
Unknown resource: 'submit'.

usage: con <resource|global action>

Available resources:
   topics    Manage topics / topic branches.
   releases  Manage releases.

Available global actions:
   sync      Clones and synchronizes local repo with origin.
   -s        Set implied resource.
   help      Prints this help.

Use 'con help [<resource> [<action>]]' for details and refer to 
http://dogfoodsoftware.com/documentatione/conveyor/ref/Branching-Strategy for
more on the underlying branch strategy which conveyor-workflow implements.

user@git-convey-wkst:~/playground/dogfoodsoftware.com/conveyor/workflow> con -s submit
Unknown resource 'submit'.
user@git-convey-wkst:~/playground/dogfoodsoftware.com/conveyor/workflow> con -s topics
Resource set as 'topics'.
user@git-convey-wkst:~/playground/dogfoodsoftware.com/conveyor/workflow> con submit
ERROR: REST call failed for 'POST /repos/DogFoodSoftware/conveyor-workflow/pulls {"title": "Pull request for issue #108","body": "Fixes #108. Generated by conveyor-workflow.","head": "topics-108-improve-con-status","base": "master"}'. (204)
ERROR: Validation Failed
Error creating PR.
user@git-convey-wkst:~/p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant