Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand custom user-agent support to also work with EAuthTokenPlatformType.MobileApp #35

Open
DoctorMcKay opened this issue Oct 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@DoctorMcKay
Copy link
Owner

DoctorMcKay commented Oct 21, 2023

Will need to likely add a constructor option that takes an object with properties:

interface ConstructorOptions {
    // ...

    mobileDeviceProperties?: MobileDeviceProperties
}

interface MobileDeviceProperties {
    mobileUserAgent?: string,     // default 'okhttp/3.12.12'
    mobileClientVersion?: string, // default '777777 3.0.0'
    deviceFriendlyName?: string,  // default 'Galaxy S22'
    osType?: number,              // default EOSType.AndroidUnknown
    gamingDeviceType?: number,    // default 528 (unknown significance)
}

Maybe we should also deprecate userAgent and rename it to webUserAgent, to differentiate it from mobileDeviceProperties.mobileUserAgent. Would also be a good idea to add a warning if webUserAgent or mobileDeviceProperties are set for inappropriate platform types.

@DoctorMcKay DoctorMcKay added the enhancement New feature or request label Oct 21, 2023
@Sadzurami
Copy link
Contributor

Maybe deprecate both machineId and userAgent, then add ability to pass deviceInfo instead?

deviceInfo should be one of IMobileDevice | IWebBrowser | ISteamClient, or something like for the sake of possible future updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants