Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement feature: settings - custom d3 path; maybe download from settings menu #20

Open
Dmytro-Shulha opened this issue Aug 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Dmytro-Shulha
Copy link
Owner

Dmytro-Shulha commented Aug 13, 2023

Since some plotly charts rely on D3 library, which is big and I do not want it to be part of plugin bundle, managing it's usage should be simplified.

As of now, the only way to use D3 is to download .min.js file from official site, place it somewhere in a vault and provide correct path in your dataviewjs block with chart code (using hardcoded output of 'create new chart' command).

Better way would be an option to set path to D3 in settings menu.
Downloading D3 lib also can be done from settings menu, but that might expose user to security risks and needs to be investigated.

This change will eliminate need to explicitly set path to D3 lib in each chart.

Separated from #4

@Dmytro-Shulha Dmytro-Shulha converted this from a draft issue Aug 13, 2023
@Dmytro-Shulha Dmytro-Shulha added the enhancement New feature or request label Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant