Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node version to 18 #75

Closed
ceilican opened this issue Jun 1, 2023 · 10 comments
Closed

Upgrade node version to 18 #75

ceilican opened this issue Jun 1, 2023 · 10 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@ceilican
Copy link
Contributor

ceilican commented Jun 1, 2023

No description provided.

@ceilican ceilican added the good first issue Good for newcomers label Jun 1, 2023
@ceilican
Copy link
Contributor Author

ceilican commented Jun 1, 2023

Make sure all dependencies are working.

We need to wait for milkomeda-c1-testnet to be merged to main first, because I think some changes were already made there that make it work with node 18.

@ceilican
Copy link
Contributor Author

ceilican commented Jun 1, 2023

cc: @AlexITC .

@KENILSHAHH
Copy link

Hey @ceilican would like to work on this issue, can you please assign it to me

@ceilican
Copy link
Contributor Author

Hi @KENILSHAHH . See my comment above from 1st of June. This issue is blocked. I will assign it to you when it becomes available, which should happen soon. In the meantime, would you like to choose another issue?

@ceilican
Copy link
Contributor Author

ceilican commented Nov 5, 2023

@KENILSHAHH @sagardxd , I have assigned this issue to both of you. Please help each other and divide the work among each other. Or, if there is not enough work to divide, we can assign one of you to another issue.

@ceilican
Copy link
Contributor Author

ceilican commented Nov 5, 2023

We need to wait for milkomeda-c1-testnet to be merged to main first

This has not happened yet. But let's proceed anyway. Have a look on that branch, because it may contain useful changes.

@keshav-nischal
Copy link

@ceilican i would like to work on this issue. Why we are not upgrading to node-20??

@ceilican
Copy link
Contributor Author

Yes, node-20 would be even better. I will assign it to you.

@ceilican
Copy link
Contributor Author

@Ronnieraj37 , i think your latest PR closes this, right?

@ceilican
Copy link
Contributor Author

Closed by #111 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants