Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate linkcheck views to ModelAdmin #189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

timobrembeck
Copy link
Contributor

@timobrembeck timobrembeck commented Apr 13, 2023

  • Add ModelAdmin for Url and Link models
  • Delete report view

Fixes #186

linkcheck

@claudep
Copy link
Contributor

claudep commented Apr 22, 2023

I'm not completely against this, but I would not like to lose some UI niceties from the previous layout. Typically, having a Recheck/Ignore buttons just near the affected link is much nicer than having to check a box at the left, go on the top of the page, open a select, chose an action and clicking on the Go button. The view/edit object links are also nice shortcuts.

@timobrembeck
Copy link
Contributor Author

@claudep I now included buttons into the list, is this how you envisioned it?

@claudep
Copy link
Contributor

claudep commented Nov 18, 2023

It begins to look rather good, however the big problem currently in my opinion is the width of the table. Even with a screen width of >1900 (~1700 with the left tab hidden), the right of the table is not accessible at all, with no horizontal scrollbar, and then the buttons are not visible (unless you make some gym trying to display the right part of the table). I know it's a current problem with the Django admin in general, however in our use case, it's really bad. Do you have an idea to mitigate that issue?

@timobrembeck
Copy link
Contributor Author

It begins to look rather good, however the big problem currently in my opinion is the width of the table. Even with a screen width of >1900 (~1700 with the left tab hidden), the right of the table is not accessible at all, with no horizontal scrollbar, and then the buttons are not visible (unless you make some gym trying to display the right part of the table). I know it's a current problem with the Django admin in general, however in our use case, it's really bad. Do you have an idea to mitigate that issue?

@claudep I played a bit around with CSS, I think now it's maybe not pretty, but at least usable on small screen resolutions, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update admin template
2 participants