Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with invalid options.. #535

Closed
vondele opened this issue Jul 10, 2024 · 5 comments · Fixed by #578
Closed

Dealing with invalid options.. #535

vondele opened this issue Jul 10, 2024 · 5 comments · Fixed by #578

Comments

@vondele
Copy link
Contributor

vondele commented Jul 10, 2024

when passing option.FooBar=11 to an engine that doesn't have it, cutechess-cli will warn as in :

Warning: New-ee6fc7e38b4aeef44862159215a56d97122f59a0 doesn't have option FooBar

If an existing option has an invalid value cutechess-cli will warn as in:

Warning: Invalid value for option Hash: -16

fishtest checks these warning messages:
https://github.com/vondele/fishtest/blob/bf62adf674e97ac69229aa879beb215c32d91ba6/worker/games.py#L1004-L1014

@gahtan-syarif
Copy link
Contributor

curretly we have this https://github.com/Disservin/fast-chess/blob/8115d51b94d80ce9104c4e2fe8722832765daaf4/app/src/engine/uci_engine.cpp#L173-#L175 but it doesnt work for some reason, possibly because stockfish doesnt stderr?

@vondele
Copy link
Contributor Author

vondele commented Jul 10, 2024

must be a cutechess check based on the uci output. SF doesn't generate such warning.

@Disservin
Copy link
Owner

but it doesnt work for some reason, possibly because stockfish doesnt stderr?

it only checks if the string was successfully send to the engine? there is no validation

@vondele
Copy link
Contributor Author

vondele commented Jul 13, 2024

A (non-critical) TODO for
official-stockfish/fishtest#2119

@Disservin
Copy link
Owner

should be fixed by the linked pr, should also have the same output syntax as cutechess

Disservin added a commit that referenced this issue Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants