Skip to content

Add benchmarks for tree creation #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alice-i-cecile opened this issue Jan 5, 2023 · 0 comments · Fixed by #401
Closed

Add benchmarks for tree creation #322

alice-i-cecile opened this issue Jan 5, 2023 · 0 comments · Fixed by #401
Labels
benchmarks Measuring performance good first issue Good for newcomers

Comments

@alice-i-cecile
Copy link
Collaborator

    > Hmm... basically looks like performance isn't affected much at all. That benchmark is only using 10 nodes and completes in microseconds so there tends to be a bit of variance on it. This is actually what I would expect. Especially as our benchmarks currently only test layout computation, and don't benchmark tree creation at all. Whereas tree creation is the only thing I would expect this to affect (if anything).

Precisely. We should probably have dedicated benches for that.

Originally posted by @alice-i-cecile in #312 (comment)

Tree creation is useful to bench as it will impact latency when swapping between different screens (views) in end user apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks Measuring performance good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant