Skip to content

Commit 0596475

Browse files
Fix grid track sizing for fit-content(percentage) and for items spanning percentage gaps (#335)
* Add tests for child spanning two max-content tracks with gaps between the tracks * Recompute available_grid_space and node_inner_size after initial track sizing rounds WIP * Suspect fix WIP * Use computed column sizes for first iteration of row track size computation * Don't limit the distribution of min-content sizes by the argument of a fit-content sizing function * Simplify fit-content tests * Resolve percentage track sizing function against node_inner_size rather than available_grid_space * Add disabled percentage fit-content test * Percentage fit content limits WIP * Distribute growth_limit changes (broken) * Simplify fit-content percent definite test * Apply fit-content limit to growth limits * When distributing space to growth_limit use base_size as affected property if growth_limit is infinite * Add min_content and max_content variants of fit-content percent definite tests * Add percent indefinite fit content tests * Remove debug logs * Remove commented out code * Fix clippy lints * Improve documentation of callback functions in distribute_item_space_to_base_size * Remove useless code Co-authored-by: Alice Cecile <[email protected]>
1 parent 78fd9cc commit 0596475

File tree

46 files changed

+1541
-289
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+1541
-289
lines changed

benches/generated/grid_fit_content_percent_definite_argument.rs

Lines changed: 33 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

benches/generated/grid_fit_content_percent_definite_max_content.rs

Lines changed: 33 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

benches/generated/grid_fit_content_percent_definite_min_content.rs

Lines changed: 33 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

benches/generated/grid_fit_content_percent_indefinite_argument.rs

Lines changed: 32 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

benches/generated/grid_fit_content_percent_indefinite_max_content.rs

Lines changed: 32 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

benches/generated/grid_fit_content_percent_indefinite_min_content.rs

Lines changed: 32 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

benches/generated/grid_fit_content_points_argument.rs

Lines changed: 4 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

benches/generated/grid_fit_content_points_max_content.rs

Lines changed: 4 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

benches/generated/grid_fit_content_points_min_content.rs

Lines changed: 4 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

benches/generated/grid_max_content_single_item_span_2.rs

Lines changed: 46 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)