Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/custom event loop #14

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

DimitriosLisenko
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #14 (71c6025) into dev (6d6bfb3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        58    +1     
  Lines         1627      1654   +27     
=========================================
+ Hits          1627      1654   +27     
Impacted Files Coverage Δ
lib/fet/processing_queue.rb 100.00% <100.00%> (ø)
lib/fet/ui/game.rb 100.00% <100.00%> (ø)
lib/fet/ui/game_loop_handler.rb 100.00% <100.00%> (ø)
lib/fet/ui/game_setup_helper.rb 100.00% <100.00%> (ø)
lib/fet/ui/level.rb 100.00% <100.00%> (ø)
lib/fet/ui/note_box_loop_handler.rb 100.00% <100.00%> (ø)
lib/fet/ui/note_boxes.rb 100.00% <100.00%> (ø)
test/fet/ui/game_test_helper.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d6bfb3...71c6025. Read the comment docs.

@DimitriosLisenko
Copy link
Owner Author

Hold off merging until ruby2d/ruby2d#182 is resolved.

@DimitriosLisenko
Copy link
Owner Author

DimitriosLisenko commented Sep 9, 2021

There's an issue where now on the correct answer the box may or may not become green for a split second before the next level. My understanding is that this is because:

  1. The event and window update queues are linked - when an event is being processed, the UI is not being updated.
  2. The entrance is now mutexed, so once the note is selected and the "level complete" event is fired, it depends on whether the update loop goes first (in which case it will show the note box as green), or the "level complete" event goes first, in which case you don't see a color change. The Ruby2D library might have a fairer scheduler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant