Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

TODO: versioning, dependencies, and load order #41

Open
LemmaEOF opened this issue Sep 4, 2018 · 2 comments
Open

TODO: versioning, dependencies, and load order #41

LemmaEOF opened this issue Sep 4, 2018 · 2 comments

Comments

@LemmaEOF
Copy link

LemmaEOF commented Sep 4, 2018

Right now, Rift doesn't have any system for versioning or dependencies. I've made a pull request on this, but don't have any system yet built for load order. Along with that, I'd like to try to see if I can move the SemVer stuff into Rift itself without relying on another system for it. The SemVer library I have is good because it can both validate and compare SemVer versioning, but that can probably be moved in pretty easily. Is there anything else that should be put into the system that people need?

@narwhalfire
Copy link

Instead of a map, it'd probably be better to have dependencies in a DAG and just construct it from riftmod.json. Also it seems a little overkill to include a library just for enforcing SemVer when you could easily do so from a RegEx.

@LemmaEOF
Copy link
Author

LemmaEOF commented Sep 5, 2018

Already done the first part with a Dependency object, and as I mentioned the SemVer should be moved in and simplified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants