Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"A mod doesn't support extended biome IDs" shows up in mods that list biomes #97

Closed
katubug opened this issue Sep 29, 2019 · 5 comments
Closed

Comments

@katubug
Copy link

katubug commented Sep 29, 2019

Hi! I'm not sure if there's an erroring biome in my pack, or if Nature's Compass is trying to load an incorrect biome added by JEID? But here is what I see when I look at the Nature's Compass GUI:

2019-09-28_20 01 58

I have tried to blacklist the error biome from appearing in the list via the Nature's Compass config, but it doesn't seem to have worked.

  • Minecraft version: 1.12.2
  • Forge version: forge-1.12.2-14.23.5.2838-universal
  • Modpack version (links to current modlist): 1.7.2
  • Mod versions: JustEnoughIDs-1.0.3-44, NaturesCompass-1.12.2-1.5.1

Please let me know if I should provide any other information. :) Thank you for your time!

@sam-kirby
Copy link
Contributor

There's no issue here, listing all biomes necessarily includes the JEID error biome. Here is an example of it being blacklisted successfully:

https://github.com/DarkPacks/SevTech-Ages/blob/master/src/config/naturescompass.cfg#L18

@katubug
Copy link
Author

katubug commented Sep 29, 2019

Ah, that helps immensely. I had tried disabling it via numeric id, which failed. I'll try the method they used. Thank you! :) I appreciate it.

@katubug katubug closed this as completed Sep 29, 2019
@Runemoro Runemoro changed the title JEID and Nature's Compass issue? "A mod doesn't support extended biome IDs" shows up in mods that list biomes Sep 30, 2019
@Runemoro Runemoro reopened this Sep 30, 2019
@Runemoro
Copy link
Member

The error biome will be removed to fix this and many other issues.

It was originally intended to make incompatibilities obvious by showing up when a mod uses the old byte biome array to get a biome, but it also shows up every time a mod lists all biomes. Almost a quarter of JEID issues are related to this (incorrect) message showing up in some biome list.

@katubug
Copy link
Author

katubug commented Oct 5, 2019

That makes sense, both the explanation and the solution. Sorry for the trouble, and thank you for helping!

@Runemoro
Copy link
Member

Runemoro commented Sep 4, 2020

See #158.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants