Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata Editing/Permissions #184

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Metadata Editing/Permissions #184

wants to merge 15 commits into from

Conversation

BryonLewis
Copy link
Collaborator

@BryonLewis BryonLewis commented Aug 22, 2024 •
edited
Loading

resolves #166
resolves #155

Note metadataKeys is the container that holds the format of what data is inside of all the metadata. It indicates data types and categorical lists of possible values as well as ranges for numerical values.

Done:

  • unlocked index for metadataKeys to indicate what metadata can be modified by any user
  • Ability to add and remove keys from metadataKeys
  • Ability to update a key value and have it update in the metadataKeys

TODO:

  • Endpoints for deleting, creating, modifying metadata information
  • Testing system and permissions interface to understand how it works.
  • Add filename (video filename) to the list of items that are displayed as well.
  • Automatically add some ffprobe information to the metadata generation (width, height, length)
  • UI Creation for deleting/adding new metadatakeys to a metadata folder
  • Add in add_Metadata_key default value so it can set on all datasets if necessary.
  • UI for modifying key values if they are unlocked and displayed.
  • Make it so that empty values if they are unlocked are shown by default
  • Testing of other users and making sure they have write access to the DIVE dataset so that they can change metadata values.
  • UI for MetadataFolder Creation (requires a folder browser to browse to root of where you want to check. This in the future may require an update endpoint to recalculate a list of the metadata in a folder/subfolders

@BryonLewis
Copy link
Collaborator Author

BryonLewis commented Sep 30, 2024 •
edited
Loading

I have built and tested the endpoints for:

  • Adding a DIVE Metadata folder by pointing it to another folder and recursively fetching items and creating a dive dataset
  • Added in DIVE_DatasetId and DIVE_Name to the values automatically added to a dive dataset. These can be hidden by default if required
  • Tested adding a new key to the DIVEMetadata, modifying permissions for it to be unclocked and then updating that key by the DIVEDataset FolderId.

UI Creation:

  • Owner needs to be able to unlock fields, add new fields, delete fields.
  • Users need to be able to modify fields that are unlocked, and delete data from unlocked fields as well.

@BryonLewis
Copy link
Collaborator Author

TODO:

  • Implement endpoints in divemetadata.service.ts (Lock/unlock, delete, add, endpoints)
  • Add in edpoints for a user editing a field
  • Add in dialog for adding new metadata field.
  • Update metadata Viewer so that users if they have write access to the folder can modify the metadata value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@BryonLewis