Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chainparamsseeds.h needs updating with static Tor seed nodes #146

Open
saltedlolly opened this issue Nov 29, 2023 · 7 comments
Open

chainparamsseeds.h needs updating with static Tor seed nodes #146

saltedlolly opened this issue Nov 29, 2023 · 7 comments

Comments

@saltedlolly
Copy link

There are currently no Tor nodes in chainparamseeds.h:
https://github.com/DigiByte-Core/digibyte/blob/develop/src/chainparamsseeds.h

To better fortify DigiByte against attack we should add some static Tor nodes to this file.

The current DigiByte static nodes list is here: https://github.com/DigiByte-Core/digibyte/blob/develop/contrib/seeds/nodes_main.txt

For comparison, see the Bitcoin static nodes list here: https://github.com/bitcoin/bitcoin/blob/master/contrib/seeds/nodes_main.txt

More info here: https://github.com/DigiByte-Core/digibyte/tree/develop/contrib/seeds

@ycagel
Copy link
Member

ycagel commented Dec 22, 2023

@saltedlolly Can this be closed since we merged #145?

@saltedlolly
Copy link
Author

It would be sensible to keep it open as a reminder to add tor nodes.

@JohnnyLawDGB
Copy link

Wouldn't there need to be some Digibyte client side changes as well in order to handle connections from Tor network?

@saltedlolly
Copy link
Author

I have not dived into exactly how to set it up for DigiByte yet, but I am pretty sure Tor integration is included. It was added to Bitcoin Core v0.21. https://bitcoin.stackexchange.com/questions/70069/how-can-i-setup-bitcoin-to-be-anonymous-with-tor

@JohnnyLawDGB
Copy link

I have not dived into exactly how to set it up for DigiByte yet, but I am pretty sure Tor integration is included. It was added to Bitcoin Core v0.21. https://bitcoin.stackexchange.com/questions/70069/how-can-i-setup-bitcoin-to-be-anonymous-with-tor

Thanks for the link, I missed that development on BitCoin Core and will put it on my list to attempt to understand. If only we had infinite time.

@saltedlolly
Copy link
Author

I think it is a great feature to have in so much that it obscures the originating IP address of nodes on the network - good for better privacy. At some point in the new year I want to look into adding support to DigiNode Tools. Hopefully it can make setup automatic. It will also then give us some tor nodes we can add to this file.

@ycagel
Copy link
Member

ycagel commented Feb 1, 2024

@saltedlolly Where do we stand on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants