-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for command ZRANGE
#1284
Comments
Hey @apoorvyadav1111 can you please assign me this issue? |
Assigned @gauravrp 🚀 |
Hi @apoorvyadav1111 , I'm interested in picking up this issue. |
Since there hasn't been any activity on ticket, assigning it to @jonathanalvares9009. |
I found some issues while testing mainly that |
Setup Command
Commands and Observations
I believe Error: ERR syntax error means not implemented. I'm open to implementing the missing parts (new to Golang will take me a lot of time tho). |
Tagging @lucifercr07 @apoorvyadav1111 ^ |
@jonathanalvares9009 Thanks for finding bugs in ZRANGE. Could you please create a separate issue for this? Also if you would like to take that up as well, please let me know and I will assign that issue to you. |
hey is this issue fixed ? can you assign this to me, would love to work on this |
Related to DiceDB#1284 Add documentation for the `ZRANGE` command in DiceDB. * Create a new file `docs/src/content/docs/commands/ZRANGE.md`. * Add an introduction paragraph about the `ZRANGE` command. * Include the syntax for the `ZRANGE` command. * List all parameters the `ZRANGE` command accepts in a table. * List all possible return values and under what condition in a table. * Describe the behavior of the `ZRANGE` command. * List all possible errors the `ZRANGE` command can throw and under what condition. * Add examples of the `ZRANGE` command and the expected output.
The documentation of the command
ZRANGE
is absent in the docs. We need your help to ensure that the documentation is complete, correct, and consistent. Completing this issue will give you much-needed exposure to how the command is implemented and the different parameters it accepts. Hence, this is a great way to build a good understanding of the project and its functionality. While still making a significant contribution. Here's what you need to do:Go through the documentation of the command and run all the examples, making sure they all work as expected
If the same command is present in Redis, then the expected output of the DiceDB command is the same as the Redis output
If the command is not in Redis, then as per your judgment, raise an issue with this template or fix the documentation and raise a pull request.
The documentation should contain the following sections in the following order
short and concise introduction paragraph about the command covering what it does
Syntax
Parameters: List all the parameters the command accepts, and ignore the section if there are no parameters
Return values: List all possible return values and under what condition
Behaviour: Describe the behavior of the command, what it does, how it does it, some internal specifics if any
Errors: List all possible errors the command can throw and under what condition
Examples: List all possible examples of the command and the expected output. Assume CLI implementation
Note: The title of the sections should be the exact strings mentioned above, like "Examples", "Return values", etc.
Note: The description of the command in Frontmatter of the command.md file is the first paragraph (introduction) of the command.
Go through the DiceDB/dice repository and explore the command implementation
to understand all possible return values
to understand all possible error values and conditions
to understand different parameters the command accepts
Please use the documentation of the SET command as the reference point and structure the
documentation of this command in a very similar way, including the following points
if you see any "Conclusion" section, remove it
the headers (h1, h2, h3) should be appropriately used
the CLI prompt should be 127.0.0.1:7379> and not anything else
Use markdown tables for parameters and return values (ref SET command documentation)
wrap any command or paramter in backticks (`) to highlight them
the section header should be capitalize as used in the SET command documentation
If you find any inconsistencies, please fix the documentation and raise the PR.
The core idea of this exercise is to ensure that the documentation is consistent, correct, and complete.
Make sure you comment on the other issues you created (if any) as a comment on this issue and also any PR (if any) that you created.
Thank you for picking this up and contributing to the DiceDB. It means a ton.
Please refer to the following files for sample structure:
The text was updated successfully, but these errors were encountered: